Skip to content

Commit 5137eae

Browse files
committed
fix after rebase
1 parent 54d715f commit 5137eae

File tree

2 files changed

+9
-23
lines changed

2 files changed

+9
-23
lines changed

example/jaeger/main.go

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,14 @@ func initTracer() func() {
3434
// Create and install Jaeger export pipeline.
3535
flush, err := jaeger.InstallNewPipeline(
3636
jaeger.WithCollectorEndpoint("http://localhost:14268/api/traces"),
37-
jaeger.WithSDK(&sdktrace.Config{
38-
DefaultSampler: sdktrace.AlwaysSample(),
39-
Resource: resource.NewWithAttributes(
37+
jaeger.WithSDKOptions(
38+
sdktrace.WithDefaultSampler(sdktrace.AlwaysSample()),
39+
sdktrace.WithResource(resource.NewWithAttributes(
4040
semconv.ServiceNameKey.String("trace-demo"),
4141
attribute.String("exporter", "jaeger"),
4242
attribute.Float64("float", 312.23),
43-
),
44-
}),
45-
jaeger.WithSDKOptions(sdktrace.WithDefaultSampler(sdktrace.AlwaysSample())),
43+
)),
44+
),
4645
)
4746
if err != nil {
4847
log.Fatal(err)

exporters/trace/jaeger/jaeger_test.go

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -303,12 +303,12 @@ func TestExporter_ExportSpan(t *testing.T) {
303303
// Create Jaeger Exporter
304304
exp, err := NewRawExporter(
305305
withTestCollectorEndpoint(),
306-
WithSDK(&sdktrace.Config{
307-
Resource: resource.NewWithAttributes(
306+
WithSDKOptions(
307+
sdktrace.WithResource(resource.NewWithAttributes(
308308
semconv.ServiceNameKey.String(serviceName),
309309
attribute.String(tagKey, tagVal),
310-
),
311-
}),
310+
)),
311+
),
312312
)
313313

314314
assert.NoError(t, err)
@@ -947,17 +947,4 @@ func TestNewExporterPipelineWithOptions(t *testing.T) {
947947
assert.True(t, len(uploadedSpans) == 1)
948948
uploadedSpan := uploadedSpans[0]
949949
assert.Equal(t, len(uploadedSpan.GetLogs()), eventCountLimit)
950-
assert.Condition(t, func() bool {
951-
tagFound := false
952-
serviceNameFound := false
953-
for _, tag := range uploadedSpan.GetTags() {
954-
if tag.GetKey() == tagKey && tag.GetVStr() == tagVal {
955-
tagFound = true
956-
}
957-
if tag.GetKey() == string(semconv.ServiceNameKey) && tag.GetVStr() == serviceName {
958-
serviceNameFound = true
959-
}
960-
}
961-
return tagFound && serviceNameFound
962-
})
963950
}

0 commit comments

Comments
 (0)