Enable user defined trace exporters #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
reviewed
Oct 27, 2023
- Use the OTLP http-protobuf exporter by default - Set runtime info in the resource, not the user agent
pellared
reviewed
Oct 27, 2023
codeboten
reviewed
Oct 28, 2023
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Should the change to the default OTLP output protocol be separated from allowing user defined exporters?
Contributor
Author
This was requested in #426 (comment) to be included here. |
pellared
approved these changes
Oct 30, 2023
edeNFed
approved these changes
Oct 30, 2023
pellared
reviewed
Oct 30, 2023
The port is only needed within the container.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to pass a trace exporter as an option to
NewInstrumentationor specify it via theOTEL_TRACES_EXPORTERenvironment variable.Resolve #234
Resolve #427