Skip to content

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented Oct 29, 2025

Contributes to #2481

Implement http and grpc tls, per schema change:

Changes

Please provide a brief description of the changes here.

  • Add a dedicated node for HttpTls
  • Add a dedicated node for GrpsTls
  • Upgrade kitchen-sink.yaml to version 1.0-rc2

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team as a code owner October 29, 2025 22:35
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.01%. Comparing base (930b694) to head (3d2084d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3726   +/-   ##
=======================================
  Coverage   90.01%   90.01%           
=======================================
  Files         225      225           
  Lines        7105     7105           
=======================================
  Hits         6395     6395           
  Misses        710      710           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff added the pr:please-review This PR is ready for review label Oct 30, 2025
@marcalff
Copy link
Member Author

@dbarker

Please review, and review #2518 as well.

@marcalff
Copy link
Member Author

@dbarker

Please approve when you have a chance.

Copy link
Member

@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. A few minor nitpicks.

@marcalff marcalff merged commit 31f78c5 into open-telemetry:main Nov 2, 2025
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-review This PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants