Skip to content

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented Jan 31, 2024

Fixes #2481

Start with examples/configuration/main.cc

Changes

Please provide a brief description of the changes here.

  • Declarative configuration is now available in opentelemetry-cpp
  • Document this in the CHANGELOG

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team January 31, 2024 00:19
@marcalff marcalff marked this pull request as draft January 31, 2024 00:28
@marcalff marcalff changed the title [IGNORE ME] Poc config yaml [RFC] Poc config yaml Feb 20, 2024
@esigo esigo self-assigned this Feb 26, 2024
@codecov
Copy link

codecov bot commented May 14, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.00%. Comparing base (0249b02) to head (a9bb682).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2518      +/-   ##
==========================================
- Coverage   90.01%   90.00%   -0.01%     
==========================================
  Files         225      225              
  Lines        7105     7105              
==========================================
- Hits         6395     6394       -1     
- Misses        710      711       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Upgrade to rapidyaml 0.6.0
@marcalff marcalff removed the pr:please-review This PR is ready for review label Oct 28, 2025
@marcalff marcalff added pr:please-review This PR is ready for review and removed pr:do-not-merge This PR is not ready to be merged. labels Oct 30, 2025
Copy link
Member

@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition to the project!

@marcalff
Copy link
Member Author

Great addition to the project!

Thanks.

According to github history for this PR, it took 273 commits to finally add 9 lines ;-)

@marcalff marcalff merged commit 930b694 into open-telemetry:main Oct 31, 2025
67 checks passed
owent pushed a commit to owent/opentelemetry-cpp that referenced this pull request Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-review This PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CONFIG] Implement file configuration

4 participants