-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[ci] Run Go unit tests with GODEBUG=fips140=only
#13926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[ci] Run Go unit tests with GODEBUG=fips140=only
#13926
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13926 +/- ##
==========================================
- Coverage 91.66% 91.65% -0.01%
==========================================
Files 652 652
Lines 42516 42516
==========================================
- Hits 38973 38970 -3
- Misses 2734 2736 +2
- Partials 809 810 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GODEBUG=fips140=only
Running
Ignore passing and skipped tests, here are the failures:
That's a total of 8 test cases that fail when
I will investigate each of these failures first to check if the HTTPS calls are indeed being made only by the test code itself; if that is the case for all such failures, we can safely add |
I think you can just set GODEBUG as an env var before running make.
Please feel free to open issues for each test occurrence failing, and request fips140-3 be considered for support. |
Thanks @atoulme, I'll run the Go unit tests as you suggested. The goal would be to eventually run these unit tests with |
GODEBUG=fips140=only
GODEBUG=fips140=only
GODEBUG=fips140=only
GODEBUG=fips140=only
Description
This PR runs all Golang unit tests in this repository with the
GODEBUG=fips140=only
environment set. This is useful to detect any FIPS-140 violations of code covered by these unit tests.Link to tracking issue
Relates to #13925
Testing
Documentation