-
Couldn't load subscription status.
- Fork 1.8k
Expose MergeCtx via exporterhelper#QueueBatchSettings #13742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13742 +/- ##
=======================================
Coverage 91.67% 91.67%
=======================================
Files 652 652
Lines 42506 42506
=======================================
+ Hits 38968 38969 +1
+ Misses 2731 2730 -1
Partials 807 807 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @lahsivjar, could you please add a changelog entry? There are instructions in the contribution guide. |
|
@bogdan-st Added changelog, thanks for the ping! |
|
I don't think the test failures are related to the PR. |
|
Please rebase, I added a change to simplify number of times we add a setting. |
|
@bogdandrutu Friendly nudge for pushing the PR forward. Is there anything blocking the PR to get this merged? |
|
@jmacd Friendly ping to get this merged, it already has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @lahsivjar please ping me on a PR where you use it
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Update a changelog entry with the proper component for fixing the tests. Example: https://github.com/open-telemetry/opentelemetry-collector/actions/runs/18419570659/job/52490942165?pr=13782 Relates to #13742 Signed-off-by: Paulo Dias <[email protected]>
Description
Exposes the
MergeCtxfunction introduced in https://github.com/open-telemetry/opentelemetry-collector/pull/13460/files toexporterhelper#QueueBatchSettings. This will allow configuring the merge context function usingexporterhelper#WithQueueBatch.Link to tracking issue
Related to #13320
Testing
N/A
Documentation
N/A