[exporter/elasticsearch]Use MergeCtx to ensure metadata keys are propagated #43575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahsivjar
commented
Oct 15, 2025
Comment on lines
+44
to
+46
| func (p metadataKeysPartitioner) MergeCtx( | ||
| ctx1, ctx2 context.Context, | ||
| ) context.Context { |
There was a problem hiding this comment.
CC: @dmitryax PTAL as per open-telemetry/opentelemetry-collector#13742 (review)
carsonip
approved these changes
Oct 16, 2025
axw
approved these changes
Oct 17, 2025
Co-authored-by: Andrew Wilkins <[email protected]>
Co-authored-by: Andrew Wilkins <[email protected]>
axw
added
the
ready to merge
ChrsMark
pushed a commit
to ChrsMark/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2025
…agated (open-telemetry#43575) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Use the `MergeCtx` function exposed in queue batch settings to configure a merge function for context when merging batches in the exporterhelper. This will allow propagting the metadata keys across the batches. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#41937 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests added. <!--Describe the documentation added.--> #### Documentation Updated. <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Andrew Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the
MergeCtxfunction exposed in queue batch settings to configure a merge function for context when merging batches in the exporterhelper. This will allow propagting the metadata keys across the batches.Link to tracking issue
Fixes #41937
Testing
Unit tests added.
Documentation
Updated.