Skip to content

chore: otel prom metadata translation pass namespace config #39826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 5, 2025
Merged

chore: otel prom metadata translation pass namespace config #39826

merged 12 commits into from
Jun 5, 2025

Conversation

jmichalek132
Copy link
Contributor

@jmichalek132 jmichalek132 commented May 2, 2025 •
edited
Loading

Description

Fixing passing metric namespace to the otel metadata translation, so when provided metric name matches the metric name in metadata

Testing

Added unit test coverage

@ArthurSens
Copy link
Member

Hey @jmichalek132, could you clarify what problem we're solving? I don't see how namespace is related to Metadata 🤔

@jmichalek132
Copy link
Contributor Author

Hey @jmichalek132, could you clarify what problem we're solving? I don't see how namespace is related to Metadata 🤔

Just realized a while a bit ago if you use the namespace feature to change the metric name and don't do the same for the metric name in metadata, your tool i.e. grafana won't be able to match them and show metadata.

@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 23, 2025
@ArthurSens
Copy link
Member

Hey @jmichalek132, could you clarify what problem we're solving? I don't see how namespace is related to Metadata 🤔

Just realized a while a bit ago if you use the namespace feature to change the metric name and don't do the same for the metric name in metadata, your tool i.e. grafana won't be able to match them and show metadata.

Good catch! Do you wanna finish the PR and add tests for it?

@github-actions github-actions bot removed the Stale label May 25, 2025
@github-actions github-actions bot requested a review from ywwg June 1, 2025 16:23
@jmichalek132 jmichalek132 marked this pull request as ready for review June 1, 2025 17:03
@jmichalek132 jmichalek132 requested review from a team as code owners June 1, 2025 17:03
ArthurSens
ArthurSens reviewed Jun 2, 2025
View reviewed changes
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I have just some comments around changelogs and tests

@jmichalek132 jmichalek132 requested a review from ArthurSens June 4, 2025 14:01
@jmichalek132 jmichalek132 requested a review from ArthurSens June 5, 2025 08:42
ArthurSens
ArthurSens approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ArthurSens ArthurSens added the ready to merge Code review completed; ready to merge by maintainers label Jun 5, 2025
@songy23 songy23 merged commit 3cf8edf into open-telemetry:main Jun 5, 2025
187 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 5, 2025
rockdaboot pushed a commit to rockdaboot/opentelemetry-collector-contrib that referenced this pull request Jun 10, 2025
@jmichalek132 @ArthurSens @rockdaboot
chore: otel prom metadata translation pass namespace config (open-tel…
425c639 
…emetry#39826)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Fixing passing metric namespace to the otel metadata translation, so
when provided metric name matches the metric name in metadata

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Added unit test coverage

---------

Co-authored-by: Arthur Silva Sens <[email protected]>
dd-jasminesun pushed a commit to DataDog/opentelemetry-collector-contrib that referenced this pull request Jun 23, 2025
@jmichalek132 @ArthurSens @dd-jasminesun
chore: otel prom metadata translation pass namespace config (open-tel…
0dba15e 
…emetry#39826)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Fixing passing metric namespace to the otel metadata translation, so
when provided metric name matches the metric name in metadata

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Added unit test coverage

---------

Co-authored-by: Arthur Silva Sens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurSens ArthurSens ArthurSens approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@rapphil rapphil Awaiting requested review from rapphil

+1 more reviewer

@ywwg ywwg ywwg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@evan-bradley evan-bradley

Labels
exporter/prometheusremotewrite pkg/translator/prometheusremotewrite ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
v0.131.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jmichalek132 @ArthurSens @ywwg @songy23 @evan-bradley