Fix PolicyGenerator setting InformOnly on root policy #154
Conversation
|
/hold |
internal/utils.go
Outdated
| } | ||
|
|
||
| // "InformOnly" should only apply to ConfigurationPolicies | ||
| if action == "InformOnly" { |
There was a problem hiding this comment.
It seems we accept any casing so this should also account for that too:
https://github.com/open-cluster-management-io/governance-policy-framework-addon/blob/6a8baf33b678533fb6ebe268edd47a421cc81143/controllers/templatesync/template_sync.go#L1345
When all ConfigurationPolicies have RemediationAction InformOnly, the root Policy is also set to have RemediationAction InformOnly. However, InformOnly is not valid on a Policy, and was thus modified to be set to inform in this case. Signed-off-by: Jeffrey Luo <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JeffeyL, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-2.10 |
|
@mprahl: once the present PR merges, I will cherry-pick it on top of release-2.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-2.9 |
|
@mprahl: once the present PR merges, I will cherry-pick it on top of release-2.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mprahl: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mprahl: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
When all ConfigurationPolicies have
RemediationActionInformOnly, the root Policy is also set to haveRemediationActionInformOnly. However,InformOnlyis not valid on a Policy, and was thus modified to be set toinformin this case.Ref: https://issues.redhat.com/browse/ACM-10534