Skip to content

Commit 6aaaa27

Browse files
committed
Fix PolicyGenerator setting InformOnly on root policy
When all ConfigurationPolicies have RemediationAction InformOnly, the root Policy is also set to have RemediationAction InformOnly. However, InformOnly is not valid on a Policy, and was thus modified to be set to inform in this case. Signed-off-by: Jeffrey Luo <[email protected]>
1 parent 19a8268 commit 6aaaa27

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

internal/utils.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -598,5 +598,10 @@ func getRootRemediationAction(policyTemplates []map[string]interface{}) string {
598598
}
599599
}
600600

601+
// "InformOnly" should only apply to ConfigurationPolicies
602+
if strings.EqualFold(action, "informonly") {
603+
action = "inform"
604+
}
605+
601606
return action
602607
}

internal/utils_test.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1627,4 +1627,12 @@ func TestGetRootRemediationAction(t *testing.T) {
16271627
objDef["spec"].(map[string]interface{})["remediationAction"] = "enforce"
16281628
expected = getRootRemediationAction(policyTemplates)
16291629
assertEqual(t, "enforce", expected)
1630+
1631+
objDef["spec"].(map[string]interface{})["remediationAction"] = "InformOnly"
1632+
expected = getRootRemediationAction(policyTemplates)
1633+
assertEqual(t, "inform", expected)
1634+
1635+
objDef["spec"].(map[string]interface{})["remediationAction"] = "iNfOrMoNlY"
1636+
expected = getRootRemediationAction(policyTemplates)
1637+
assertEqual(t, "inform", expected)
16301638
}

0 commit comments

Comments
 (0)