[Task]: Align styling of "Additional information" table in resource page to table in Dataset page #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds French input option for site title
* Added some additional instructions specific to a M1
* Displays report an error form only when there are resources * <Should only show Report an Error message if the resource is Open> * Checks if both the resouce and package are Open to post the Report an Error banner * Changed the line so it checks the dataset's access level
* Facet pill is displayed when there are no search results * Removes choices from translate_facets.html
* Uses translated site title function for html title tag * remove header.html in external template directory * change any remaining g.site_title to the translated site title function
* Displays report an error form only when there are resources * <Should only show Report an Error message if the resource is Open> * Checks if both the resouce and package are Open to post the Report an Error banner * Changed the line so it checks the dataset's access level * Added French translations to aria-labels * Fixed capitalization for one of the msgid
* Spelling change to French aria-label
* Adopts ld+json script for the dataset page using schema.org properties. * Removes itemprop and other schema.org attributes throughout dataset and resource page and consolidates it into the ld+json
* Adds data attributes for QA on Ministries page and Groups page
* Updates to tab labels on ministry and dataset pages * New activity stream page added to Group directory * Fixed closing tag
* fix Ld+json script causing a 500 error on the dataset's groups and activity stream pages
…464) * sorting using solr and making it work with toggling between languages * Code clean up and new managed-schema file
* Auto-update footer date
* Additional info table on dataset page switched to grid * Resource page additional info table + switching to ds grid
* Adds condition to facet search to prevent TypeError being thrown intermittently.
* Removes pagination from Ministries' page * Displays all Ministries on one page * Implements natsort for sorting Ministry titles * Reduces Ministries' page loading time * Reworks Ministries' index view function to return all fields for faster and more efficient sorting
Removed duplicate import statement for datetime Co-authored-by: Kobikah Chandran <[email protected]>
upgrade version to v2.1.13 in setup.py. Release v2.1.13 includes the following features: * Fix datetime import duplication causing 500 error
* Change Additional Information table from <table> to <div>s
* Creates validator to strip whitespace from fluent fields. * Adds validator to dataset and resource schemas for titles and names
* Adds condition to facet search to prevent TypeError being thrown intermittently.
* Removes pagination from Ministries' page * Displays all Ministries on one page * Implements natsort for sorting Ministry titles * Reduces Ministries' page loading time * Reworks Ministries' index view function to return all fields for faster and more efficient sorting
|
KatiRG
approved these changes
Jan 29, 2024
|
@Alexandra-Green ready for merge but needs a rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR accomplishes
Issue(s) addressed
What needs review