Skip to content

Condition to prevent Nonetype concatenate error #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2024
Merged

Condition to prevent Nonetype concatenate error #492

merged 1 commit into from
Jan 19, 2024

Conversation

aimalkhan
Copy link
Collaborator

@aimalkhan aimalkhan commented Jan 19, 2024 •
edited
Loading

What this PR accomplishes & Issue(s) addressed

  • Adds condition to facet search to prevent TypeError: unsupported operand type(s) for +: 'NoneType' and 'Markup' this error being thrown intermittently.

Issue(s) addressed

  • DATA-818

What needs review

  • TypeError: unsupported operand type(s) for +: 'NoneType' and 'Markup' error is no longer thrown.

@aimalkhan
Copy link
Collaborator Author

@aimalkhan aimalkhan merged commit 37f5192 into develop Jan 19, 2024
@aimalkhan aimalkhan deleted the search_concatenate_error branch January 19, 2024 22:29
@aimalkhan aimalkhan mentioned this pull request Jan 25, 2024
Merged
aimalkhan added a commit that referenced this pull request Jan 25, 2024
@aimalkhan
release v2.1.14 (#498)
dc81856 
Release v2.1.14 includes the following features:

* Improve Ministries page by removing page #493
* Simplify logs #492
* UI improvements #490 #491
aimalkhan added a commit that referenced this pull request Jan 25, 2024
@aimalkhan
condition to prevent Nonetype concatenate error (#492)
dc7224a 
* Adds condition to facet search to prevent TypeError being thrown intermittently.
aimalkhan added a commit that referenced this pull request Jan 25, 2024
@aimalkhan
release v2.1.14 (#498)
8b87378 
Release v2.1.14 includes the following features:

* Improve Ministries page by removing page #493
* Simplify logs #492
* UI improvements #490 #491
@aimalkhan aimalkhan mentioned this pull request Jan 25, 2024
Merged
aimalkhan added a commit that referenced this pull request Jan 25, 2024
@aimalkhan
condition to prevent Nonetype concatenate error (#492)
eebd512 
* Adds condition to facet search to prevent TypeError being thrown intermittently.
aimalkhan added a commit that referenced this pull request Jan 25, 2024
@aimalkhan
release v2.1.14 (#498)
6fff7ab 
Release v2.1.14 includes the following features:

* Improve Ministries page by removing page #493
* Simplify logs #492
* UI improvements #490 #491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aimalkhan