Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
8c671cb
Added editorconfig based on that in nvaccess/nvda
SaschaCowley Feb 14, 2025
962a234
lf instead of crlf
SaschaCowley Feb 14, 2025
497f668
Add initial ruff configuration, based on that of NVDA
SaschaCowley Feb 14, 2025
a4f79e9
remove explicit inheritance from `object`
SaschaCowley Mar 27, 2025
bb59a9e
Initial run ov monkeytype over the code base
SaschaCowley May 21, 2025
253d607
Remove inheritance from object
SaschaCowley May 21, 2025
b60378e
Fix a couple of type annotations
SaschaCowley May 21, 2025
4748695
Rename and improve ruff.toml
SaschaCowley May 21, 2025
431c23f
Fix up type annotations by removing Optional, Union, Dict, List etc
SaschaCowley May 21, 2025
d46f773
Read certificates as binary
SaschaCowley Jun 3, 2025
26267e1
Move type hints into server.py
SaschaCowley Jun 3, 2025
e8c7cd1
Fix logging
SaschaCowley Jun 3, 2025
f2c7b5e
Fix ambiguous name
SaschaCowley Jun 3, 2025
03a618a
Fix some typing issues
SaschaCowley Jun 3, 2025
0104e77
Docstrings for channel
SaschaCowley Jun 3, 2025
217d049
Docstrings for Handler
SaschaCowley Jun 3, 2025
b046099
Docstrings for User
SaschaCowley Jun 3, 2025
856be45
Docstrings for ServerState
SaschaCowley Jun 3, 2025
3d479d5
Add some comments
SaschaCowley Jun 3, 2025
65c52b3
Enable pyright, with all failing tests disabled
SaschaCowley Jun 4, 2025
780ca10
Fix reportDeprecated
SaschaCowley Jun 4, 2025
b18c973
Fix unannotated functions
SaschaCowley Jun 4, 2025
2711ecf
Resolved several type issues
SaschaCowley Jun 4, 2025
d851607
Move to pyproject.toml for ruff config
SaschaCowley Jun 4, 2025
282581a
Remove no longer needed type stubs
SaschaCowley Jun 4, 2025
2418759
Update pre-commit config for CI
SaschaCowley Jun 4, 2025
96f3da9
Pre-commit updates
SaschaCowley Jun 4, 2025
8e191e9
Remove pyrightCI and remove pyrightLocal alias
SaschaCowley Jun 4, 2025
f854857
Experimental pyright GHA
SaschaCowley Jun 4, 2025
3543a3f
Try using uvx to run pyright
SaschaCowley Jun 4, 2025
521dc54
Update deps
SaschaCowley Jun 4, 2025
ba433e4
Try running with uv run
SaschaCowley Jun 5, 2025
e807136
Sync environment then use uvx
SaschaCowley Jun 5, 2025
418bfc2
Include dev
SaschaCowley Jun 5, 2025
8680525
Use uv run
SaschaCowley Jun 5, 2025
21f0a79
Apply suggestions from code review
SaschaCowley Jun 5, 2025
1f36a0d
Update .github/workflows/pyright.yml
SaschaCowley Jun 5, 2025
0e4f425
Fix pyright error in server.py
SaschaCowley Jun 19, 2025
5bb8dd5
Fix typ annotations on test.TestGenerateKey._test
SaschaCowley Jun 19, 2025
650df67
Silence pyright errors caused by incorrect types in ttwisted/Zope int…
SaschaCowley Jun 19, 2025
1882501
Bring coverage back up to 100%
SaschaCowley Jun 19, 2025
d810bb6
camelCase variables, methods and attributes in server.Channel
SaschaCowley Jun 19, 2025
b448bbc
camelCase attributes, methods and variables in server.Handler
SaschaCowley Jun 19, 2025
993cb65
camelCase attributes, methods and variables in server.User
SaschaCowley Jun 19, 2025
2d90454
camelCase attributes, methods and variables in server.RemoteServerFac…
SaschaCowley Jun 19, 2025
26288ab
camelCase attributes, methods and variables in server.ServerState
SaschaCowley Jun 19, 2025
6012376
Fix some straggling snake_case
SaschaCowley Jun 19, 2025
b6810ce
Minor sweeks
SaschaCowley Jun 19, 2025
3ef7d0e
Try using a composite setup action for coverage
SaschaCowley Jun 19, 2025
2f51125
Add default shell to actions/setup-environment
SaschaCowley Jun 19, 2025
6a20da4
run -> runs
SaschaCowley Jun 19, 2025
7d1ec7a
Move shell to steps with runs
SaschaCowley Jun 19, 2025
2150f69
Use setup-environment with pyright ci
SaschaCowley Jun 19, 2025
1d8fae1
Add pyright output to GHA summary
SaschaCowley Jun 19, 2025
ba78907
Test restricting perms
SaschaCowley Jun 19, 2025
201c518
Test restricting perms
SaschaCowley Jun 19, 2025
6d37a55
Restrict perms of pyright action
SaschaCowley Jun 19, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
root = true

[*]
end_of_line = lf
insert_final_newline = true

[*.py]
charset = utf-8
indent_style = tab
tab_width = 4
trim_trailing_whitespace = true
max_line_length = 110

[*.{yml,yaml}]
indent_style = space
charset = utf-8
indent_size = 2
trim_trailing_whitespace = true
11 changes: 11 additions & 0 deletions .github/actions/setup-environment/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: 'Setup CI Environment'
description: 'Setup the environment in which CI scripts for the NVDA Remote Access server can be run'

runs:
using: "composite"
steps:
- name: Install the latest version of uv
uses: astral-sh/[email protected]
- name: Setup environment
shell: bash
run: uv sync --dev
8 changes: 2 additions & 6 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,10 @@ jobs:
coverage:
name: Check coverage with coverage.py
runs-on: ubuntu-latest
permissions:
pull-requests: write
permissions: {}
steps:
- uses: actions/[email protected]
- name: Install the latest version of uv
uses: astral-sh/[email protected]
- name: Setup environment
run: uv sync --dev
- uses: ./.github/actions/setup-environment
- name: Run unit tests
run: uv run coverage run
- name: Report coverage
Expand Down
21 changes: 21 additions & 0 deletions .github/workflows/pyright.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Check types with Pyright

on:
push:
branches:
- main

pull_request:
branches:
- main

jobs:
pyright:
name: Check types with pyright
runs-on: ubuntu-latest
permissions: {}
steps:
- uses: actions/[email protected]
- uses: ./.github/actions/setup-environment
- name: Run pyright
run: uv run pyright >> $GITHUB_STEP_SUMMARY
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ reportOptionalMemberAccess = false
# The following option causes problems due to dynamic member access
reportUnknownArgumentType = false


[tool.ruff]
line-length = 110

Expand Down
Loading