Update to follow our code standards more closely #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaCowley
changed the title
seanbudd
reviewed
Jun 3, 2025
SaschaCowley
force-pushed
the
codeStandards
branch
from
ff391e2 to
200e084
Compare
|
It is recommended to add GH-docker and docker-hub, which will make deploying the server more convenient later. |
|
@dpy013 - could you open a new issue for considering creating a docker env |
seanbudd
reviewed
Jun 5, 2025
seanbudd
approved these changes
Jun 5, 2025
Merged
Co-authored-by: Sean Budd <[email protected]>
Co-authored-by: Sean Budd <[email protected]>
SaschaCowley
force-pushed
the
codeStandards
branch
from
74b9da1 to
650df67
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
seanbudd
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the remote relay server to follow NV Access's code standards more closely. Type hints and docstrings have been added.
Type hints were generated with MonkeyType and manually reviewed. Some comments are vague or incomplete as some parts of the code are unclear to me.