Skip to content

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Aug 14, 2025

Changes to number of Brillig opcodes executed

Generated at commit: 899024fba9d4ea4480b0138ab252a7b63fe267df, compared to commit: c7ae241ae1791b11c3470a26522efdbddfcdf469

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
bit_shifts_runtime_inliner_max -27 ✅ -8.82%
bit_shifts_runtime_inliner_min -27 ✅ -8.82%
bit_shifts_runtime_inliner_zero -27 ✅ -8.82%
u16_support_inliner_max -4 ✅ -11.11%

Full diff report 👇
Program Brillig opcodes (+/-) %
bit_shifts_comptime_inliner_max 79 (-1) -1.25%
bit_shifts_comptime_inliner_min 79 (-1) -1.25%
bit_shifts_comptime_inliner_zero 79 (-1) -1.25%
binary_operator_overloading_inliner_min 221 (-4) -1.78%
binary_operator_overloading_inliner_zero 221 (-4) -1.78%
binary_operator_overloading_inliner_max 205 (-4) -1.91%
u128_type_inliner_max 90 (-2) -2.17%
u128_type_inliner_min 90 (-2) -2.17%
u128_type_inliner_zero 90 (-2) -2.17%
u16_support_inliner_min 44 (-4) -8.33%
u16_support_inliner_zero 44 (-4) -8.33%
bit_shifts_runtime_inliner_max 279 (-27) -8.82%
bit_shifts_runtime_inliner_min 279 (-27) -8.82%
bit_shifts_runtime_inliner_zero 279 (-27) -8.82%
u16_support_inliner_max 32 (-4) -11.11%

Copy link
Contributor

github-actions bot commented Aug 14, 2025

Changes to Brillig bytecode sizes

Generated at commit: 899024fba9d4ea4480b0138ab252a7b63fe267df, compared to commit: c7ae241ae1791b11c3470a26522efdbddfcdf469

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
u16_support_inliner_min -8 ✅ -14.29%
u16_support_inliner_zero -8 ✅ -14.29%
u16_support_inliner_max -8 ✅ -16.67%

Full diff report 👇
Program Brillig opcodes (+/-) %
bit_shifts_comptime_inliner_max 102 (-1) -0.97%
bit_shifts_comptime_inliner_min 102 (-1) -0.97%
bit_shifts_comptime_inliner_zero 102 (-1) -0.97%
binary_operator_overloading_inliner_max 372 (-8) -2.11%
binary_operator_overloading_inliner_min 213 (-8) -3.62%
binary_operator_overloading_inliner_zero 213 (-8) -3.62%
u128_type_inliner_max 132 (-6) -4.35%
u128_type_inliner_min 132 (-6) -4.35%
u128_type_inliner_zero 132 (-6) -4.35%
bit_shifts_runtime_inliner_max 448 (-36) -7.44%
bit_shifts_runtime_inliner_min 448 (-36) -7.44%
bit_shifts_runtime_inliner_zero 448 (-36) -7.44%
inactive_signed_bitshift_inliner_max 70 (-10) -12.50%
inactive_signed_bitshift_inliner_min 70 (-10) -12.50%
inactive_signed_bitshift_inliner_zero 70 (-10) -12.50%
u16_support_inliner_min 48 (-8) -14.29%
u16_support_inliner_zero 48 (-8) -14.29%
u16_support_inliner_max 40 (-8) -16.67%

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 9aeed93 Previous: c7ae241 Ratio
test_report_zkpassport_noir-ecdsa_ 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Base automatically changed from gd/issue_9022 to master August 14, 2025 16:52
@TomAFrench TomAFrench force-pushed the tf/sweeping-stuff-into-the-shifts branch from 230457e to 2187209 Compare August 14, 2025 19:29
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 43b8228 Previous: bae9236 Ratio
sha512-100-bytes 2.026 s 1.539 s 1.32

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@TomAFrench TomAFrench force-pushed the tf/sweeping-stuff-into-the-shifts branch from 43b8228 to 6996166 Compare August 15, 2025 14:05
@TomAFrench TomAFrench changed the base branch from master to tf/bitshift-simplification August 15, 2025 14:05
@TomAFrench TomAFrench force-pushed the tf/sweeping-stuff-into-the-shifts branch from 6996166 to 33dc781 Compare August 15, 2025 16:49
Copy link
Contributor

github-actions bot commented Aug 15, 2025

Changes to circuit sizes

Generated at commit: 899024fba9d4ea4480b0138ab252a7b63fe267df, compared to commit: c7ae241ae1791b11c3470a26522efdbddfcdf469

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
u128_type -6 ✅ -4.35% -15 ✅ -0.32%
bit_shifts_runtime -36 ✅ -6.62% -37 ✅ -0.76%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
inactive_signed_bitshift 75 (-5) -6.25% 2,845 (-4) -0.14%
binary_operator_overloading 88 (-4) -4.35% 3,300 (-5) -0.15%
u16_support 34 (-4) -10.53% 2,792 (-5) -0.18%
u128_type 132 (-6) -4.35% 4,607 (-15) -0.32%
bit_shifts_runtime 508 (-36) -6.62% 4,858 (-37) -0.76%

Base automatically changed from tf/bitshift-simplification to master August 16, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant