Skip to content

perf: avoid intermediate promise on BodyReadable.dump #4459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
Merged

perf: avoid intermediate promise on BodyReadable.dump #4459

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b1ef6d
perf: avoid intermediate promise on `BodyReadable.dump`
Uzlopak Aug 25, 2025
c23c435
also test stacktraces
Uzlopak Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions lib/api/readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,24 +262,26 @@ class BodyReadable extends Readable {
* @param {AbortSignal} [opts.signal] An AbortSignal to cancel the dump.
* @returns {Promise<null>}
*/
async dump (opts) {
dump (opts) {
const signal = opts?.signal

if (signal != null && (typeof signal !== 'object' || !('aborted' in signal))) {
throw new InvalidArgumentError('signal must be an AbortSignal')
return Promise.reject(new InvalidArgumentError('signal must be an AbortSignal'))
}

const limit = opts?.limit && Number.isFinite(opts.limit)
? opts.limit
: 128 * 1024

signal?.throwIfAborted()
if (signal?.aborted) {
return Promise.reject(signal.reason ?? new AbortError())
}

if (this._readableState.closeEmitted) {
return null
return Promise.resolve(null)
}

return await new Promise((resolve, reject) => {
return new Promise((resolve, reject) => {
if (
(this[kContentLength] && (this[kContentLength] > limit)) ||
this[kBytesRead] > limit
Expand Down
Loading