Skip to content

Conversation

@Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 25, 2025

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

Copy link
Member

@ronag ronag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the call stack for any errors significantly worse?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 25, 2025

I checked it and it doesnt seem to differ at all.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 25, 2025

@ronag
@mcollina

Extended tests to check the stacktraces. If I run the modified client-request.js test against main, it passes. So basically, this PR does not modifiy the stack traces at all, so no worsening is in place.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 00972e4 into main Aug 25, 2025
49 of 53 checks passed
@Uzlopak Uzlopak deleted the core-bodyreadable-dump branch August 25, 2025 16:45
@github-actions github-actions bot mentioned this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants