Skip to content

Conversation

F3n67u
Copy link
Member

@F3n67u F3n67u commented Jun 28, 2022

This test is the top 1 flaky test all last week. I think we would better mark it as flaky temporally.

After #43470 merged, we could remove this flaky mark.

Refs:

cc @ShogunPanda @MrJithil

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 28, 2022
@F3n67u F3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2022
@nodejs-github-bot
Copy link
Collaborator

@F3n67u F3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2022
@nodejs-github-bot
Copy link
Collaborator

@ShogunPanda
Copy link
Contributor

Thanks @F3n67u!
It was on my TODO list but I was overwhelmed.
Shall we fast-track this to make people's life better?

@F3n67u
Copy link
Member Author

F3n67u commented Jun 28, 2022

Thanks @F3n67u!
It was on my TODO list but I was overwhelmed.
Shall we fast-track this to make people's life better?

Yes! I am not a collaborator. Could you add the fast-track label, please?

@ShogunPanda ShogunPanda added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 28, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @ShogunPanda. Please 👍 to approve.

@LiviaMedeiros LiviaMedeiros added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 28, 2022
ShogunPanda pushed a commit that referenced this pull request Jun 28, 2022
@ShogunPanda
Copy link
Contributor

Landed in bc5f9e1

@LiviaMedeiros LiviaMedeiros removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 28, 2022
@F3n67u F3n67u deleted the flaky-test-http-server-request-timeouts-mixed branch June 28, 2022 11:07
targos pushed a commit that referenced this pull request Jul 12, 2022
targos pushed a commit that referenced this pull request Jul 31, 2022
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants