doc: improve doc/markdown file organization coherence #31771
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged the CODE_OF_CONDUCT.md and doc/guides/contributing/coc.md files into a single code of conduct file Refs: nodejs#31741
Changed security_release_process.md to security-release-process.md to stay consistent with file naming Refs: nodejs#31741
Moved writing-and-running-benchmarks to doc/guides/ directory Fixes: nodejs#31741
Updated updating-root-certs.md to maintaining-root-certs.md Fixes: nodejs#31741
Moved COLLABORATOR_GUIDE, CPP_STYLE_GUIDE, and internal-api to the appropriate directories Fixes: nodejs#31741
Moved STYLE_GUIDE.md to guides/documentation-style.md Fixes: nodejs#31741
Updated broken links after merging doc/guides/contributing/coc.md
nodejs-github-bot
added
the
meta
richardlau
reviewed
Feb 13, 2020
Member
There was a problem hiding this comment.
A quick search for writing-and-running-benchmarks shows that the current location is referenced elsewhere so moving the file will break those links unless they are also updated.
The same applies to CPP_STYLE_GUIDE and COLLABORATOR_GUIDE.
PR-URL: nodejs#31719 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Add more information about why it is advisable not to use `.FromJust()` etc. on Maybe(Local)s, and general information about termination exceptions. PR-URL: nodejs#31720 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Moves directions for LTS release from the Release repo to Node docs. Fixes: nodejs/Release#530 PR-URL: nodejs#31724 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Remove magic number and measure amount of difference should be allowable between consecutive stat() calls. PR-URL: nodejs#31726 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Two scenarios should be tested: 1. The completion is triggered and the result is printed before the next invocation. 2. The completion is triggered multiple times right after each other without waiting for the result. In that case only the last result should be printed. The first scenario did not need a timeout while the latter did not need a timeout for the second invocation. PR-URL: nodejs#31708 Fixes: nodejs#31094 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#31705 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: James M Snell <[email protected]>
Was resolved in nodejs@e559842. PR-URL: nodejs#31701 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#31692 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Update my personal email address from [email protected] (tired) to [email protected] (wired). PR-URL: nodejs#31670 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
PR-URL: nodejs#31620 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#31662 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Add prerequisites for Arch Linux and derivatives in BUILDING.md. PR-URL: nodejs#31669 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
In benchmark directory this changes for loops using var to let when it applies for consistency PR-URL: nodejs#28958 Reviewed-By: Anna Henningsen <[email protected]>
Use `let` in module, napi, net, os, path, process, querystring, streams and string_decoder. PR-URL: nodejs#31592 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs@e559842 made writable/readable computed with a legacy mode if the properties are written to. LazyTransform still unecessarily wrote to these properties causing a performance regression. Fixes: nodejs#31739 PR-URL: nodejs#31742 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
jasnell
reviewed
Feb 13, 2020
| @@ -1,4 +1,44 @@ | |||
| # Code of Conduct | |||
Member
There was a problem hiding this comment.
@conordavenport this one should be left as is, with the link over to the nodejs/admin repo
Contributor
Author
There was a problem hiding this comment.
Oh right, thanks for pointing that out
PR-URL: nodejs#27517 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Contributor
|
I suggest all the guides be renamed to For every file that's renamed I suggest a Thank you! |
Refs: nodejs#31727 PR-URL: nodejs#31728 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]>
There was an edge case where if _destroy calls the error callback later than one tick the iterator would complete early and not propgate the error. PR-URL: nodejs#31314 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: nodejs#31700 Reviewed-By: Anna Henningsen <[email protected]>
Merged the CODE_OF_CONDUCT.md and doc/guides/contributing/coc.md files into a single code of conduct file Refs: nodejs#31741
Changed security_release_process.md to security-release-process.md to stay consistent with file naming Refs: nodejs#31741
Moved writing-and-running-benchmarks to doc/guides/ directory Fixes: nodejs#31741
Updated updating-root-certs.md to maintaining-root-certs.md Fixes: nodejs#31741
Moved COLLABORATOR_GUIDE, CPP_STYLE_GUIDE, and internal-api to the appropriate directories Fixes: nodejs#31741
Moved STYLE_GUIDE.md to guides/documentation-style.md Fixes: nodejs#31741
Updated broken links after merging doc/guides/contributing/coc.md
This reverts commit 19fbcc1.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve markdown and documentation file organization.
Fixes: #31741
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes