Skip to content

lib: fix few comment typos in fs/watchers.js #31705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

lib: fix few comment typos in fs/watchers.js #31705

wants to merge 3 commits into from

Conversation

@lundibundi
Copy link
Member

@lundibundi lundibundi commented Feb 9, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Feb 9, 2020
Trott
Trott reviewed Feb 9, 2020
View reviewed changes
Trott
Trott reviewed Feb 9, 2020
View reviewed changes
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 9, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 9, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29053/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 12, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29087/

addaleax pushed a commit that referenced this pull request Feb 13, 2020
@lundibundi @addaleax
lib: fix few comment typos in fs/watchers.js
bc55b57 
PR-URL: #31705
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax
Copy link
Member

addaleax commented Feb 13, 2020

Landed in bc55b57

@addaleax addaleax closed this Feb 13, 2020
@lundibundi lundibundi deleted the few-comment-typo-fixes-watcher branch February 13, 2020 20:27
@codebytere
Copy link
Member

codebytere commented Feb 17, 2020

@lundibundi should this go back to v13.x? It'll need a manual backport if yes.

@lundibundi
Copy link
Member Author

lundibundi commented Feb 18, 2020

I don't think it is needed unless it will help with other conflicts.

@BethGriggs BethGriggs mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+2 more reviewers

@antsmartian antsmartian antsmartian approved these changes

@devnexen devnexen devnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.