Fix decoding ReadPropertyMultipleAck + add more ReadRangeValueTypes #6
Conversation
mnbbrown
force-pushed
the
fix-read-property-multiple-read-range-value
branch
2 times, most recently
from
c54cc6d to
34a1947
Compare
| buf, | ||
| TagNumber::ContextSpecificOpening(Self::DATE_TIME_TAG), | ||
| "ReadRangeItem decode", | ||
| "ReadRangeItem decode open date time", |
There was a problem hiding this comment.
let me know if I should back these changes out - but it made it much easier to debug.
There was a problem hiding this comment.
They are a little redundant because you have access to the Tag there but if they made your life easier then I have no problem at all putting them in. They are there for debugging after all.
|
I don't think it's a good time to add anything right now or you're going to have some painful merge conflicts to resolve. I'm busy making significant changes to solve these ownership issues. |
|
Ok the major refactor is done for now. I'm not 100% happy with it (ideally I would like to get rid of all the lifetimes if the |
src/network_protocol/data_link.rs
Outdated
| Self { | ||
| function, | ||
| npdu, | ||
| raw_payload: &[], |
There was a problem hiding this comment.
As mentioned in a comment in this PR, this should not be here as keeping track of segments is not the job of the codec. It should be done at a higher level.
mnbbrown
force-pushed
the
fix-read-property-multiple-read-range-value
branch
from
b800b45 to
44edc59
Compare
|
Thanks for your changes, they look good! My apologies for taking my time in getting back to this. |
2 participants
ReadPropertyMultipleAck::new_from_bufdoesn't take a reader, so itwill attempt to decode from the beginning of the slice. This fixes it to
only pass the remaining buf.
Add more support for decoding ReadRangeValueType (bool, unsigned,
signed and NULL).