Add support for decoding ReadRangeValueType (bool, unsigned,

signed and NULL).

Author: mnbbrown

src/application_protocol/confirmed.rs

@@ -377,7 +377,7 @@ impl<'a> ComplexAckService<'a> {
             }
             ConfirmedServiceChoice::ReadPropMultiple => {
                 let buf = &buf[reader.index..reader.end];
-                let service = ReadPropertyMultipleAck::new_from_buf(buf);
+                let service = ReadPropertyMultipleAck::new_from_buf(&buf[reader.index..]);
                 Ok(ComplexAckService::ReadPropertyMultiple(service))
             }
             ConfirmedServiceChoice::ReadRange => {

src/application_protocol/services/read_range.rs

@@ -330,35 +330,35 @@ impl<'a> ReadRangeItem<'a> {
             reader,
             buf,
             TagNumber::ContextSpecificOpening(Self::DATE_TIME_TAG),
-            "ReadRangeItem decode",
+            "ReadRangeItem decode open date time",
         )?;
         Tag::decode_expected(
             reader,
             buf,
             TagNumber::Application(ApplicationTagNumber::Date),
-            "ReadRangeItem decode",
+            "ReadRangeItem decode date",
         )?;
         let date = Date::decode(reader, buf)?;
         Tag::decode_expected(
             reader,
             buf,
             TagNumber::Application(ApplicationTagNumber::Time),
-            "ReadRangeItem decode",
+            "ReadRangeItem decode time",
         )?;
         let time = Time::decode(reader, buf)?;
         Tag::decode_expected(
             reader,
             buf,
             TagNumber::ContextSpecificClosing(Self::DATE_TIME_TAG),
-            "ReadRangeItem decode",
+            "ReadRangeItem decode close date time",
         )?;
 
         // value
         Tag::decode_expected(
             reader,
             buf,
             TagNumber::ContextSpecificOpening(Self::VALUE_TAG),
-            "ReadRangeItem decode",
+            "ReadRangeItem decode open value",
         )?;
         let tag = Tag::decode(reader, buf)?;
         let value_type: ReadRangeValueType = match tag.number {
@@ -371,22 +371,37 @@ impl<'a> ReadRangeItem<'a> {
             ReadRangeValueType::Real => {
                 let value = f32::from_be_bytes(reader.read_bytes(buf)?);
                 ReadRangeValue::Real(value)
-            }
+            },
+            ReadRangeValueType::Bool => {
+                let bytes = reader.read_byte(buf)?;
+                ReadRangeValue::Bool(bytes > 0)
+            },
+            ReadRangeValueType::Unsigned => {
+                let value = u32::from_be_bytes(reader.read_bytes(buf)?);
+                ReadRangeValue::Unsigned(value)
+            },
+            ReadRangeValueType::Signed => {
+                let value = i32::from_be_bytes(reader.read_bytes(buf)?);
+                ReadRangeValue::Signed(value)
+            },
+            ReadRangeValueType::Null => {
+                ReadRangeValue::Null
+            },
             x => return Err(Error::Unimplemented(Unimplemented::ReadRangeValueType(x))),
         };
         Tag::decode_expected(
             reader,
             buf,
             TagNumber::ContextSpecificClosing(Self::VALUE_TAG),
-            "ReadRangeItem decode",
+            "ReadRangeItem decode close value",
         )?;
 
         // status flags
         Tag::decode_expected(
             reader,
             buf,
             TagNumber::ContextSpecific(Self::STATUS_FLAGS_TAG),
-            "ReadRangeItem decode",
+            "ReadRangeItem decode status",
         )?;
         let status_flags = BitString::decode(&PropertyId::PropStatusFlags, tag.value, reader, buf)?;