feat(API): Provide can ID parser for out_strm_list_by_id
#145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`out_strm_list_by_id` might contain either LIN or CAN frames IDs without a way to distinguish them so we can't completely abstract it like we did for IDs in the actual Frames. Instead the parsing logic from `CanFrame` was extracted and abstracted so it can be reused with this property (`CanIdentifier`). Fixes ni#115 BREAKING CHANGE: `CanFrame` now accepts a single `CanIdentifier` rather than an `(int, bool)`. An `int` can still be passed in as a short-form and will be interpreted as a non-extended id.
2 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
out_strm_list_by_idmight contain either LIN or CAN frames IDs without away to distinguish them so we can't completely abstract it like we did for
IDs in the actual Frames. Instead the parsing logic from
CanFramewasextracted and abstracted so it can be reused with this property
(
CanIdentifier).Fixes #115
BREAKING CHANGE:
CanFramenow accepts a singleCanIdentifierratherthan an
(int, bool). Anintcan still be passed in as a short-formand will be interpreted as a non-extended id.
toxsuccessfully runs, including unit tests and style checks (see CONTRIBUTING.md).