Bookmark manager no longer tracks per database #859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The experimental bookmark manager feature was changed to no longer track
bookmarks per database.
This effectively changes the signature of almost all bookmark
manager related methods:
- `neo4j.BookmarkManger` and `neo4j.AsyncBookmarkManger` abstract base
classes:
- ``update_bookmarks`` has no longer a ``database`` argument.
- ``get_bookmarks`` has no longer a ``database`` argument.
- The ``get_all_bookmarks`` method was removed.
- The ``forget`` method was removed.
- `neo4j.GraphDatabase.bookmark_manager` and
`neo4j.AsyncGraphDatabase.bookmark_manager` factory methods:
- ``initial_bookmarks`` is no longer a mapping from database name
to bookmarks but plain bookmarks.
- ``bookmarks_supplier`` no longer receives the database name as
an argument.
- ``bookmarks_consumer`` no longer receives the database name as
an argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neo4j.BookmarkMangerandneo4j.AsyncBookmarkMangerabstract base classes: -update_bookmarkshas no longer adatabaseargument. -get_bookmarkshas no longer adatabaseargument. - Theget_all_bookmarksmethod was removed. - Theforgetmethod was removed.neo4j.GraphDatabase.bookmark_managerandneo4j.AsyncGraphDatabase.bookmark_managerfactory methods:initial_bookmarksis no longer a mapping from database name to bookmarks but plain bookmarks.bookmarks_supplierno longer receives the database name as an argument. -bookmarks_consumerno longer receives the database name as an argument.Depends on