Update Bookmark Manager interface #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with 5.0, Fabric is enabled by default. It 1. allows multiple databases to be interacted with in a single transaction, and 2. ensures bookmarks encode the state of all databases. Hence, the Bookmark Manager can be simplified while also improving its performance (by having to send less bookmarks to the server). This PR implements the changes need on the bookmark manager API and behaviour.
…ed to test_should_send_all_db_bookmarks_and_replace_it_by_the_new_one
the bookmarks_supplier can be called 5 or 4 times.
See the original code:
```
if len(get_bookmarks_calls) == 5:
self.assertEqual(
[
# acquire connection
["system"],
# first tx
[None],
# name resolution
["system"],
# acquire connection
["system"],
# second tx
[None]
],
get_bookmarks_calls
)
else:
self.assertEqual(4, len(get_bookmarks_calls))
self.assertEqual(
[
# acquire connection
["system"],
# first tx
[None],
# name resolution
["system"],
# second tx
[None]
],
get_bookmarks_calls
)
```
Co-Authored-By: Rouven Bauer <[email protected]>
thelonelyvulpes
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with 5.0, Fabric is enabled by default.
It
This PR implements the changes need on the bookmark manager API and behaviour.