Skip to content

Text slug #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2017
Merged

Text slug #369

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43c7e13
Added String slugging
jastax Apr 4, 2017
762e02b
Default delim for slug
jastax Apr 4, 2017
001a7d7
less-naive slugging
jastax Apr 6, 2017
9145283
regexp in one
jastax Apr 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/java/apoc/text/Strings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,4 +160,12 @@ public String format(@Name("text") String text, @Name("params") List<Object> par
if (params == null) return text;
return String.format(Locale.ENGLISH,text, params.toArray());
}

@UserFunction
@Description("apoc.text.slug(text, delim) - slug the text with the given delimiter")
public String slug(@Name("text") String text, @Name(value = "delim", defaultValue = "-") String delim) {
if (text == null) return null;
if (delim == null) return null;
return text.replace(" ", delim).replace(delim+delim, delim);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably use replaceAll("\s+",delim) for all whitespace
or \W+ for non-word-characters

}
}
9 changes: 9 additions & 0 deletions src/test/java/apoc/text/StringsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,5 +246,14 @@ public void testRegexGroupsForNPE() {
testCall(db, "RETURN apoc.text.regexGroups(null,'<link (\\\\w+)>(\\\\w+)</link>') AS result", row -> { });
testCall(db, "RETURN apoc.text.regexGroups('abc',null) AS result", row -> { });
}

@Test
public void testSlug() {
testCall(db, "RETURN apoc.text.slug('a b','-') AS value", row -> assertEquals("a-b", row.get("value")));
testCall(db, "RETURN apoc.text.slug('a- b','-') AS value", row -> assertEquals("a-b", row.get("value")));
testCall(db, "RETURN apoc.text.slug('a b c') AS value", row -> assertEquals("a-b-c", row.get("value")));
testCall(db, "RETURN apoc.text.slug('a b c', '.') AS value", row -> assertEquals("a.b.c", row.get("value")));

}

}