Text slug #369
Merged
Text slug #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure, if this is what was requested though ;) |
jexp
reviewed
Apr 5, 2017
src/main/java/apoc/text/Strings.java
Outdated
| public String slug(@Name("text") String text, @Name(value = "delim", defaultValue = "-") String delim) { | ||
| if (text == null) return null; | ||
| if (delim == null) return null; | ||
| return text.replace(" ", delim).replace(delim+delim, delim); |
There was a problem hiding this comment.
probably use replaceAll("\s+",delim) for all whitespace
or \W+ for non-word-characters
|
Looks good, please have a look at my comment. Perhpas also test for subsequent space? |
|
Better like this? :) Anything else to improve? |
|
something is wrong now, there is a lot of other changes, can you rebase your work onto the latest master state? and then push to the PR branch again |
|
sure, sorry :) |
jexp
reviewed
Apr 7, 2017
src/main/java/apoc/text/Strings.java
Outdated
| public String slug(@Name("text") String text, @Name(value = "delim", defaultValue = "-") String delim) { | ||
| if (text == null) return null; | ||
| if (delim == null) return null; | ||
| return text.trim() |
There was a problem hiding this comment.
it's actually much easier `.replaceAll("[\W\s]+","delim")
|
Thanks a lot !! |
albertodelazzari
pushed a commit
to albertodelazzari/neo4j-apoc-procedures
that referenced
this pull request
Jun 28, 2017
|
I found a problem, the slug is not set to lowercase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #343