Skip to content

[MU3] Fix #286153: Check box "Show MIDI controls in mixer" in Preferences/Score page has no effect #7145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2020
Merged

[MU3] Fix #286153: Check box "Show MIDI controls in mixer" in Preferences/Score page has no effect #7145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions mscore/mixer/mixer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ char userRangeToReverb(double v) { return (char)qBound(0, static_cast<int>(v / 1

Mixer::Mixer(QWidget* parent)
: QDockWidget(qApp->translate("Mixer", "Mixer"), parent),
showDetails(true),
showDetails(preferences.getBool(PREF_IO_MIDI_SHOWCONTROLSINMIXER)),
Copy link
Contributor Author

@Jojo-Schmitz Jojo-Schmitz Dec 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow this doesn't seem to result in the prefecence being read and set when opening the Mixer for the 1st time?!?

trackHolder(nullptr)
{

Expand Down Expand Up @@ -452,8 +452,9 @@ void Mixer::updateTracks()
// midiPrefsChanged
//---------------------------------------------------------

void Mixer::midiPrefsChanged(bool)
void Mixer::midiPrefsChanged(bool showMidiControls)
{
showDetailsToggled(showMidiControls);
updateTracks();
}

Expand Down Expand Up @@ -503,6 +504,7 @@ void MuseScore::showMixer(bool visible)

if (mixer == 0) {
mixer = new Mixer(this);
mixer->showDetailsToggled(preferences.getBool(PREF_IO_MIDI_SHOWCONTROLSINMIXER));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what brings it to senses on the 1st open.

mscore->stackUnder(mixer);
if (synthControl)
connect(synthControl, SIGNAL(soundFontChanged()), mixer, SLOT(updateTrack()));
Expand Down