[MU3] Fix #286153: Check box "Show MIDI controls in mixer" in Preferences/Score page has no effect #7145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
commented
Dec 22, 2020
| Mixer::Mixer(QWidget* parent) | ||
| : QDockWidget(qApp->translate("Mixer", "Mixer"), parent), | ||
| showDetails(true), | ||
| showDetails(preferences.getBool(PREF_IO_MIDI_SHOWCONTROLSINMIXER)), |
There was a problem hiding this comment.
Somehow this doesn't seem to result in the prefecence being read and set when opening the Mixer for the 1st time?!?
…core page has no effect
Jojo-Schmitz
commented
Dec 22, 2020
|
|
||
| if (mixer == 0) { | ||
| mixer = new Mixer(this); | ||
| mixer->showDetailsToggled(preferences.getBool(PREF_IO_MIDI_SHOWCONTROLSINMIXER)); |
There was a problem hiding this comment.
This is what brings it to senses on the 1st open.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 3, 2021
Before musescore#7145, to fix https://musescore.org/en/node/286153, that setting got ignored, so it always showed the full mixer.
vpereverzev
pushed a commit
that referenced
this pull request
Feb 3, 2021
Before #7145, to fix https://musescore.org/en/node/286153, that setting got ignored, so it always showed the full mixer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/286153