Skip to content

[code-infra] Increase JSDOM test parallelism #20179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 3, 2025
Merged

[code-infra] Increase JSDOM test parallelism #20179

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f6a76fc
[code-infra] Experiment: test parallelism
Janpot Nov 3, 2025
7deb0a8
Update config.yml
Janpot Nov 3, 2025
dc304d9
Update config.yml
Janpot Nov 3, 2025
bb856b0
Update config.yml
Janpot Nov 3, 2025
cad70dc
Update config.yml
Janpot Nov 3, 2025
5b85065
add blob reporter
Janpot Nov 3, 2025
079addd
Update vitest.config.mts
Janpot Nov 3, 2025
0f1878b
exit correctly
Janpot Nov 3, 2025
f840409
Update config.yml
Janpot Nov 3, 2025
eed5110
break a test on purpose
Janpot Nov 3, 2025
78b1286
Update config.test.ts
Janpot Nov 3, 2025
a32c9fb
Update config.yml
Janpot Nov 3, 2025
bb0c7e3
Update config.yml
Janpot Nov 3, 2025
08bacdd
Update config.yml
Janpot Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,12 @@ jobs:
react-version: << parameters.react-version >>
- run:
name: Test JSDOM
command: pnpm test:unit:jsdom
command: |
# Fully saturate all the available CPUs by splitting the tests in 1 shard per CPU
pnpm exec concurrently "pnpm test:unit:jsdom --reporter=blob --shard=1/2" "pnpm test:unit:jsdom --reporter=blob --shard=2/2" || TEST_EXIT_CODE=$?
Copy link
Member

@JCQuintas JCQuintas Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose circleci never implemented a proper way to detect cores 😆

Copy link
Member Author

@Janpot Janpot Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I'm not mistaken, availableParallelism detects correct amount of logical CPUs in circle ci. just feels a bit like overkill to write a wrapper script for this.

pnpm exec vitest run --merge-reports
# Reports merged, we can now exit with the stored code
exit ${TEST_EXIT_CODE:-0}
- store_test_results:
path: test-results
test_browser:
Expand Down
Loading