[code-infra] Increase JSDOM test parallelism #20179
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-20179--material-ui-x.netlify.app/ Bundle size report
|
Janpot
added
type: enhancement
Janpot
changed the title
JCQuintas
approved these changes
Nov 3, 2025
| command: pnpm test:unit:jsdom | ||
| command: | | ||
| # Fully saturate all the available CPUs by splitting the tests in 1 shard per CPU | ||
| pnpm exec concurrently "pnpm test:unit:jsdom --reporter=blob --shard=1/2" "pnpm test:unit:jsdom --reporter=blob --shard=2/2" || TEST_EXIT_CODE=$? |
There was a problem hiding this comment.
I suppose circleci never implemented a proper way to detect cores 😆
There was a problem hiding this comment.
if I'm not mistaken, availableParallelism detects correct amount of logical CPUs in circle ci. just feels a bit like overkill to write a wrapper script for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have 2 CPUs available for the medium resource class. But having the tests run serially cause a lot of underutiization.
We can fully saturate them instead by sharding our tests and have 2 runs in parallel.
This makes optimal use of the available resources and brings the runtime of this job down by ~35% and thus also the consumed credits. Which brings it right into the ballpark of our second slowest job (
test_browser). If we want we can increase resource class to medium+ and add another shard to dip below the runtime of that job.For the test output it works as follows:
--reporter=bloboverrides the configured reporters to a representation that can be pieced together withvitest run --merge-reportsinto what's configured by the vitest config:We make sure to propagate the exit code afterwards as to make the job fail.