Skip to content

[DataGrid] Fix toolbar slotProps not being applied #19769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

[DataGrid] Fix toolbar slotProps not being applied #19769

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
612d5d9
[DataGrid] Fix toolbar slotProps not being applied
sai6855 Sep 30, 2025
bafe322
Merge branch 'master' into toolbarr-props
sai6855 Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/x-data-grid/src/components/toolbarV8/GridToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ function GridToolbar(props: GridToolbarProps) {
printOptions,
additionalItems,
additionalExportMenuItems,
...other
Copy link
Contributor Author

@sai6855 sai6855 Sep 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if omitting other props from Toolbar was intentional, but including them resolved the issue

} = props;
const apiRef = useGridApiContext();
const rootProps = useGridRootProps();
Expand All @@ -112,7 +113,7 @@ function GridToolbar(props: GridToolbarProps) {
const closeExportMenu = () => setExportMenuOpen(false);

return (
<Toolbar>
<Toolbar {...other}>
{rootProps.label && <GridToolbarLabel>{rootProps.label}</GridToolbarLabel>}

{!rootProps.disableColumnSelector && (
Expand Down
Loading