Skip to content

[DataGrid] Fix toolbar slotProps not being applied #19769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2025
Merged

[DataGrid] Fix toolbar slotProps not being applied #19769

merged 2 commits into from
Oct 1, 2025

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Sep 30, 2025 •
edited
Loading

@sai6855 sai6855 added type: bug It doesn't behave as expected. scope: data grid Changes related to the data grid. labels Sep 30, 2025
@sai6855 sai6855 marked this pull request as draft September 30, 2025 18:21
@mui-bot
Copy link

mui-bot commented Sep 30, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19769--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 🔺+134B(+0.03%) 🔺+24B(+0.02%)
@mui/x-data-grid-pro 🔺+134B(+0.03%) 🔺+58B(+0.04%)
@mui/x-data-grid-premium 🔺+134B(+0.02%) 🔺+34B(+0.02%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against bafe322

sai6855
sai6855 commented Sep 30, 2025
View reviewed changes
packages/x-data-grid/src/components/toolbarV8/GridToolbar.tsx
printOptions,
additionalItems,
additionalExportMenuItems,
...other
Copy link
Contributor Author

@sai6855 sai6855 Sep 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if omitting other props from Toolbar was intentional, but including them resolved the issue

@sai6855 sai6855 requested a review from KenanYusuf September 30, 2025 18:45
@sai6855 sai6855 marked this pull request as ready for review September 30, 2025 18:45
KenanYusuf
KenanYusuf approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@KenanYusuf KenanYusuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sai6855 sai6855 merged commit cc561de into mui:master Oct 1, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenanYusuf KenanYusuf KenanYusuf approved these changes

@MBilalShafi MBilalShafi Awaiting requested review from MBilalShafi

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees
No one assigned
Labels
scope: data grid Changes related to the data grid. type: bug It doesn't behave as expected.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] SlotProps toolbar doesn't seem to work
3 participants
@sai6855 @mui-bot @KenanYusuf