Skip to content

[pickers] Ensure reference value is not updated for invalid values #19635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

[pickers] Ensure reference value is not updated for invalid values #19635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions packages/x-date-pickers/src/internals/hooks/useField/useFieldState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,19 +412,19 @@ export const useFieldState = <

// If `prop.value` changes, we update the state to reflect the new value
if (value !== state.lastExternalValue) {
let sections: InferFieldSection<TValue>[];
if (
const isActiveDateInvalid =
sectionToUpdateOnNextInvalidDateRef.current != null &&
!adapter.isValid(
fieldValueManager.getDateFromSection(
value,
state.sections[sectionToUpdateOnNextInvalidDateRef.current.sectionIndex],
),
)
) {
);
let sections: InferFieldSection<TValue>[];
if (isActiveDateInvalid) {
sections = setSectionValue(
sectionToUpdateOnNextInvalidDateRef.current.sectionIndex,
sectionToUpdateOnNextInvalidDateRef.current.value,
sectionToUpdateOnNextInvalidDateRef.current!.sectionIndex,
sectionToUpdateOnNextInvalidDateRef.current!.value,
);
} else {
sections = getSectionsFromValue(value);
Expand All @@ -435,11 +435,9 @@ export const useFieldState = <
lastExternalValue: value,
sections,
sectionsDependencies: { format, isRtl, locale: adapter.locale },
referenceValue: fieldValueManager.updateReferenceValue(
adapter,
value,
prevState.referenceValue,
),
referenceValue: isActiveDateInvalid
? prevState.referenceValue
: fieldValueManager.updateReferenceValue(adapter, value, prevState.referenceValue),
tempValueStrAndroid: null,
}));
}
Expand Down
Loading