Skip to content

[pickers] Ensure reference value is not updated for invalid values #19635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

[pickers] Ensure reference value is not updated for invalid values #19635

merged 1 commit into from
Sep 19, 2025

Conversation

michelengelen
Copy link
Member

Fixes #18640

Thanks to @flaviendelangle for the solution.

I tested this manually as well and it seems to fix the problem

@mui-bot
Copy link

mui-bot commented Sep 19, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19635--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 🔺+33B(+0.01%) 🔺+19B(+0.03%)
@mui/x-date-pickers-pro 🔺+29B(+0.01%) 🔺+14B(+0.02%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 4119d2b

flaviendelangle
flaviendelangle approved these changes Sep 19, 2025
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the severity of the regression, I think it's safe to assume that this will improve the situation 😬

@michelengelen michelengelen enabled auto-merge (squash) September 19, 2025 17:10
@michelengelen michelengelen added type: regression A bug, but worse, it used to behave as expected. scope: pickers Changes related to the date/time pickers. labels Sep 19, 2025
@michelengelen michelengelen self-assigned this Sep 19, 2025
@michelengelen michelengelen merged commit cf468cd into mui:master Sep 19, 2025
23 of 24 checks passed
bernardobelchior pushed a commit to bernardobelchior/mui-x that referenced this pull request Sep 22, 2025
@michelengelen @bernardobelchior
[pickers] Ensure reference value is not updated for invalid values (m…
c72fb01 
…ui#19635)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@LukasTy LukasTy Awaiting requested review from LukasTy

Assignees

@michelengelen michelengelen

Labels

scope: pickers Changes related to the date/time pickers. type: regression A bug, but worse, it used to behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[pickers][DateRangePicker] Value changes on manual input

3 participants

@michelengelen @mui-bot @flaviendelangle