Skip to content

[DataGridPro] Keep the drop effect if keepColumnPositionIfDraggedOutside is enabled #19372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2025
Merged

[DataGridPro] Keep the drop effect if keepColumnPositionIfDraggedOutside is enabled #19372

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
082edee
keep the drop effect if we are keeping the column position if dragged…
arminmeh Aug 28, 2025
b0ce996
return early
arminmeh Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/x-data-grid-pro/src/hooks/features/columnReorder/useGridColumnReorder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import * as React from 'react';
import { RefObject } from '@mui/x-internals/types';
import composeClasses from '@mui/utils/composeClasses';
import ownerDocument from '@mui/utils/ownerDocument';
import { useRtl } from '@mui/system/RtlProvider';
import {
CursorCoordinates,
Expand Down Expand Up @@ -357,6 +358,27 @@ export const useGridColumnReorder = (
[apiRef, logger, isRtl],
);

React.useEffect(() => {
if (!props.keepColumnPositionIfDraggedOutside) {
return () => {};
}

const doc = ownerDocument(apiRef.current.rootElementRef!.current);
const listener = (event: DragEvent) => {
if (event.dataTransfer) {
// keep the drop effect if we are keeping the column position if dragged outside
// https://github.com/mui/mui-x/issues/19183#issuecomment-3202307783
event.preventDefault();
event.dataTransfer.dropEffect = 'move';
}
};

doc.addEventListener('dragover', listener);
return () => {
doc.removeEventListener('dragover', listener);
};
}, [apiRef, props.keepColumnPositionIfDraggedOutside]);

useGridEvent(apiRef, 'columnHeaderDragStart', handleDragStart);
useGridEvent(apiRef, 'columnHeaderDragEnter', handleDragEnter);
useGridEvent(apiRef, 'columnHeaderDragOver', handleDragOver);
Expand Down
Loading