Skip to content

[DataGridPro] Keep the drop effect if keepColumnPositionIfDraggedOutside is enabled #19372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2025
Merged

[DataGridPro] Keep the drop effect if keepColumnPositionIfDraggedOutside is enabled #19372

merged 2 commits into from
Aug 29, 2025

Conversation

arminmeh
Copy link
Contributor

@arminmeh arminmeh commented Aug 28, 2025 •
edited by cherniavskii
Loading

Fixes #19183 (comment)

The problem occurs when the column is dragged outside of the drop zone. Other elements change the dropEffect to none, which makes the animation go back to the initial position.

Before: https://stackblitz.com/edit/dxwxkwjy?file=src%2FDemo.tsx

To test, use the first example at
https://deploy-preview-19372--material-ui-x.netlify.app/x/react-data-grid/column-ordering/
and add keepColumnPositionIfDraggedOutside

@arminmeh arminmeh added type: bug It doesn't behave as expected. scope: data grid Changes related to the data grid. feature: Reordering Related to the data grid Reordering feature labels Aug 28, 2025
@arminmeh arminmeh mentioned this pull request Aug 28, 2025
Closed
@mui-bot
Copy link

mui-bot commented Aug 28, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19372--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 🔺+318B(+0.04%) 🔺+71B(+0.03%)
@mui/x-data-grid-premium 🔺+318B(+0.04%) 🔺+61B(+0.02%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) ▼-3B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 🔺+1B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against b0ce996

@arminmeh arminmeh added the plan: Pro Impact at least one Pro user. label Aug 28, 2025
cherniavskii
cherniavskii approved these changes Aug 28, 2025
View reviewed changes
@arminmeh arminmeh merged commit 48dd549 into mui:master Aug 29, 2025
21 checks passed
@arminmeh arminmeh deleted the fix-column-reorder-drop-effect branch August 29, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@MBilalShafi MBilalShafi Awaiting requested review from MBilalShafi

@michelengelen michelengelen Awaiting requested review from michelengelen

Assignees

No one assigned

Labels

feature: Reordering Related to the data grid Reordering feature plan: Pro Impact at least one Pro user. scope: data grid Changes related to the data grid. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[data grid] Column reordering does not always stick even when drag preview shows column in new location

3 participants

@arminmeh @mui-bot @cherniavskii