Skip to content

Conversation

arminmeh
Copy link
Contributor

@arminmeh arminmeh commented Aug 21, 2025

Closes #19235

Slot removed in #17291

Since we are adding our own component for unsorted state we should allow users to change it to something else

@arminmeh arminmeh added scope: data grid Changes related to the data grid. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. customization: dom Component's DOM customizability, e.g. slot. labels Aug 21, 2025
@mui-bot
Copy link

mui-bot commented Aug 21, 2025

Deploy preview: https://deploy-preview-19268--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 🔺+40B(+0.01%) 🔺+13B(+0.01%)
@mui/x-data-grid-pro 🔺+40B(+0.01%) 🔺+3B(0.00%)
@mui/x-data-grid-premium 🔺+40B(+0.01%) 🔺+2B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 7fabe15

@duynguyen-kun
Copy link

Not sure if it's covered or not, but I don't see the localization key for this icon being brought back?

@arminmeh
Copy link
Contributor Author

Not sure if it's covered or not, but I don't see the localization key for this icon being brought back?

there were no additional keys for this state
I don't see any keys being removed in the PR that removed the slot

@arminmeh arminmeh merged commit 5c3ef9a into mui:master Aug 21, 2025
26 checks passed
@arminmeh arminmeh deleted the unsorted-icon-slot branch August 21, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customization: dom Component's DOM customizability, e.g. slot. scope: data grid Changes related to the data grid. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs][data grid] Why was columnUnsortedIcon removed from the slots API?

4 participants