[docs][data grid] Why was `columnUnsortedIcon` removed from the slots API?

[duynguyen-kun]

Related page

https://mui.com/x/migration/migration-data-grid-v7/#slots

Kind of issue

Unclear explanations

Issue description

In Data Grid v7, I was able to customize the column unsorted icon via the slots API, but now it's removed without any backward compatibility or alternatives. Can you explain and at least provide a legacy prop?.

Current version: DataGrid with Pro license 8.10.1

How the code currently looks:

      const slots = useMemo<DataGridProps['slots']>(
        () => ({
          columnSortedAscendingIcon: ColumnSortedAscendingIcon, // This line applies to both ascending and unsorted icons
          columnSortedDescendingIcon: ColumnSortedDescendingIcon,
          columnUnsortedIcon: ColumnUnsortedIcon, // This line is no longer valid in v8
          ...slotsProp,
        }),
        [slotsProp],
      );

Context

The intention behind is that when hovered, the unsorted icon is the arrow pointing up and it's confusing to a group of users who think that is being sorted in ascending/descending directions. What I wanna do is to replace that with the below icon for a better visual meaning.

Search keywords: data grid, docs, migration, v8, slots API, unsorted icon

[romgrk]

The reason I removed it is because the slots ending in Icon were all a 1-1 mapping to actual icons, whereas columnUnsortedIcon was not, it contained logic. The idea is that we wanted to make the icons replaceable so that users can avoid shipping (and paying the bundle-size cost for) icons that they don't actually use.

We could add back a compatibility slot.

[romgrk]

@mui/xgrid Can someone from the grid team handle this? It might also be interesting to use an unsorted icon by default, the rationale for using it makes sense.

[duynguyen-kun]

The reason I removed it is because the slots ending in Icon were all a 1-1 mapping to actual icons, whereas columnUnsortedIcon was not, it contained logic. The idea is that we wanted to make the icons replaceable so that users can avoid shipping (and paying the bundle-size cost for) icons that they don't actually use.

We could add back a compatibility slot.

Well, the reason for paying the bundle-size cost can be discussed since somes are willing to ship them. And we should consider the impact of removing things for a wide-used, complex package like Grid. Appreciate if the Grid team can bring it back, maybe in the next minor or whatever?

[arminmeh]

To allow overrides, I will add this slot back and leave the decision to change the default icon outside of that PR.

cc @KenanYusuf

[duynguyen-kun]

To allow overrides, I will add this slot back and leave the decision to change the default icon outside of that PR.

cc @KenanYusuf

Thanks for the fast response @arminmeh Do you know when is the next release? I've just seen the 8.10.2 a few hours ago.

[arminmeh]

Thanks for the fast response @arminmeh Do you know when is the next release? I've just seen the 8.10.2 a few hours ago.

@duynguyen-kun we do releases weekly.
I expect the PR to be merged before the next release, so the update should be published in about 1 week

[duynguyen-kun]

Perfect. Help me close the issue when the PR is merged. Thanks again 💯