Skip to content

[charts-premium] Make x-charts-premium releasable #18959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 22, 2025
Merged

[charts-premium] Make x-charts-premium releasable #18959

merged 16 commits into from
Sep 22, 2025

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas self-assigned this Jul 29, 2025
@JCQuintas JCQuintas added plan: Premium Impact at least one Premium user. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Jul 29, 2025
@mui-bot
Copy link

mui-bot commented Jul 29, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-18959--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 🔺+50B(+0.01%) 🔺+27B(+0.02%)
@mui/x-data-grid-premium 🔺+50B(+0.01%) 🔺+27B(+0.02%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 🔺+50B(+0.01%) 🔺+27B(+0.02%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 🔺+50B(+0.02%) 🔺+28B(+0.03%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 🔺+50B(+0.06%) 🔺+29B(+0.11%)

Details of bundle changes

Generated by 🚫 dangerJS against 52746d0

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 29, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #18959 will not alter performance

Comparing JCQuintas:release-charts-premium (52746d0) with master (980daf0)1

Summary

✅ 10 untouched

Footnotes

  1. No successful run was found on master (5d0f159) during the generation of this report, so 980daf0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

bernardobelchior
bernardobelchior reviewed Jul 31, 2025
View reviewed changes
JCQuintas
JCQuintas commented Jul 31, 2025
View reviewed changes
packages/x-license/src/useLicenseVerifier/useLicenseVerifier.test.tsx
const licenseKey = generateLicense({
expiryDate: new Date(3001, 0, 0, 0, 0, 0, 0),
orderNumber: 'MUI-123',
const planCombinations = [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworked the license tests to be more complete and take charts-premium into account

@JCQuintas JCQuintas marked this pull request as ready for review July 31, 2025 15:50
@JCQuintas JCQuintas requested a review from alexfauquette as a code owner July 31, 2025 15:50
bernardobelchior
bernardobelchior approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@bernardobelchior bernardobelchior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@arminmeh arminmeh mentioned this pull request Aug 5, 2025
Merged
34 tasks
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 12, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link

This pull request has been inactive for 30 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 15 days.

@github-actions github-actions bot added the stale Inactive for 7 days (issues) or 30 days (PRs); closed after 5 or 15 more days if no update. label Sep 11, 2025
@github-actions github-actions bot removed PR: out-of-date The pull request has merge conflicts and can't be merged. stale Inactive for 7 days (issues) or 30 days (PRs); closed after 5 or 15 more days if no update. labels Sep 12, 2025
@JCQuintas JCQuintas merged commit 48513a6 into mui:master Sep 22, 2025
22 checks passed
@JCQuintas JCQuintas deleted the release-charts-premium branch September 22, 2025 09:33
bernardobelchior added a commit to bernardobelchior/mui-x that referenced this pull request Sep 22, 2025
@JCQuintas @bernardobelchior @alexfauquette
[charts-premium] Make x-charts-premium releasable (mui#18959)
653d435 
Signed-off-by: Jose C Quintas Jr <[email protected]>
Co-authored-by: Bernardo Belchior <[email protected]>
Co-authored-by: alex <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bernardobelchior bernardobelchior bernardobelchior approved these changes

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees

@JCQuintas JCQuintas

Labels

plan: Premium Impact at least one Premium user. scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JCQuintas @mui-bot @bernardobelchior @alexfauquette