Skip to content

[charts-premium] Make x-charts-premium releasable #18959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

[charts-premium] Make x-charts-premium releasable #18959

wants to merge 13 commits into from
+793 −180

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas self-assigned this Jul 29, 2025
@JCQuintas JCQuintas added plan: Premium Impact at least one Premium user type: enhancement This is not a bug, nor a new feature scope: charts Changes or issues related to the charts product labels Jul 29, 2025
@mui-bot
Copy link

mui-bot commented Jul 29, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-18959--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle Parsed Size Gzip Size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid/DataGrid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 🔺+64B(+0.01%) 🔺+27B(+0.02%)
@mui/x-data-grid-pro/DataGridPro 🔺+64B(+0.01%) 🔺+22B(+0.02%)
@mui/x-data-grid-premium 🔺+64B(+0.01%) 🔺+28B(+0.02%)
@mui/x-data-grid-premium/DataGridPremium 🔺+64B(+0.01%) 🔺+22B(+0.01%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 🔺+64B(+0.02%) 🔺+31B(+0.03%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 🔺+64B(+0.02%) 🔺+28B(+0.03%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 🔺+64B(+0.08%) 🔺+27B(+0.11%)

Details of bundle changes

Generated by 🚫 dangerJS against 60a39da

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 29, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #18959 will degrade performances by 10.41%

Comparing JCQuintas:release-charts-premium (60a39da) with master (359c486)1

Summary

❌ 1 regressions
✅ 9 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ ScatterChartPro with big data amount 390 ms 435.4 ms -10.41%

Footnotes

  1. No successful run was found on master (b62e79d) during the generation of this report, so 359c486 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

bernardobelchior
bernardobelchior reviewed Jul 31, 2025
View reviewed changes
JCQuintas
JCQuintas commented Jul 31, 2025
View reviewed changes
packages/x-license/src/useLicenseVerifier/useLicenseVerifier.test.tsx
const licenseKey = generateLicense({
expiryDate: new Date(3001, 0, 0, 0, 0, 0, 0),
orderNumber: 'MUI-123',
const planCombinations = [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworked the license tests to be more complete and take charts-premium into account

@JCQuintas JCQuintas marked this pull request as ready for review July 31, 2025 15:50
@JCQuintas JCQuintas requested a review from alexfauquette as a code owner July 31, 2025 15:50
bernardobelchior
bernardobelchior approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@bernardobelchior bernardobelchior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@arminmeh arminmeh mentioned this pull request Aug 5, 2025
Open
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernardobelchior bernardobelchior bernardobelchior approved these changes

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees

@JCQuintas JCQuintas

Labels
plan: Premium Impact at least one Premium user scope: charts Changes or issues related to the charts product type: enhancement This is not a bug, nor a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JCQuintas @mui-bot @bernardobelchior @alexfauquette