Skip to content

Conversation

arminmeh
Copy link
Contributor

@arminmeh arminmeh commented May 27, 2025

Previews:

https://deploy-preview-18021--material-ui-x.netlify.app/x/react-data-grid/charts-integration/
https://deploy-preview-18021--material-ui-x.netlify.app/x/react-charts/data-grid-integration/

Todo:

  • Add more options for the line chart
  • Add more options for the pie chart
  • Add area chart
  • Add donut chart
  • Handle row grouping better (remove regular column from the list and automatically pick up grouped values)
  • Allow control of which columns should be available for categories/series
  • Add support for multiple categories - Initially charts will be limited to one category. Multiple categories support is a follow-up
  • Limit number of categories/series
  • Support pivoting
  • Verify chart integration with live data update
  • Add show/hide toggle for categories/series to allow quick updates (like in pivoting)
  • Update drag and drop UI to clearly show that string columns cannot go to series
  • Adjust (create new) data set to better demo the feature Pivoting examples are looking nice
  • Improve empty data overlays
  • Add tests
  • Update the docs on the grid side
  • Add docs on charts side
  • Update side panel to work the same as the preference panel (allowing multiple panel contents and swapping between them automatically) - extracted to [DataGridPremium] Sidebar content and state is managed the same way as for preference panel #18741
  • Add charts panel to the sidebar value - depends on [DataGridPremium] Sidebar content and state is managed the same way as for preference panel #18741
  • Allow setting the initial state for the chart config form
  • Allow customization of the chart renderer
  • Add column menu item to open the charts configuration panel (like pivoting)
  • Add localization strings
  • Improve tabs a11y
  • Add checks for the type compatibility between grid and charts
  • Allow multiple charts to be controlled with one grid
  • Allow chart to be excluded from the grid changes
  • Add data source example
  • Allow string fields in the series if row grouping is enabled and they are aggregated by size
  • Update grouping/pivoting model when categories are updated
  • Put integration feature under an opt-in flag
  • Add support for multiple categories - [charts] Grouped axes #17931
  • Prepare x-charts-premium for release - [charts-premium] Make x-charts-premium releasable #18959
  • Define the behavior when pivoting fields that were previously removed are being added again - Follow-up point added

Out of scope:
Points added to the follow-up issue #19435

  • Support Radar, Heatmap, and Sankey charts (context)
  • Allow charts event handling
  • Highlight columns used for the chart in the grid
  • Allow the source of the data to be set to the selected rows or just the current page instead of all visible data
  • Improve grouping state updates when categories are updated (context)
  • Add a warning when pivoting change will affect charts configuration (context).

@arminmeh arminmeh requested review from a team May 27, 2025 10:05
@arminmeh arminmeh added the type: new feature Expand the scope of the product to solve a new problem. label May 27, 2025
@mui-bot
Copy link

mui-bot commented May 27, 2025

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-18021--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 🔺+2.4KB(+0.62%) 🔺+777B(+0.66%)
@mui/x-data-grid-pro 🔺+2.42KB(+0.52%) 🔺+727B(+0.51%)
@mui/x-data-grid-premium 🔺+37.8KB(+6.41%) 🔺+10.3KB(+5.77%)
@mui/x-charts 🔺+3.93KB(+1.22%) 🔺+1.01KB(+1.01%)
@mui/x-charts-pro 🔺+3.93KB(+0.95%) 🔺+974B(+0.75%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 🔺+5B(+0.01%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 🔺+2B(+0.01%)

Details of bundle changes

Generated by 🚫 dangerJS against 3ef4d69

@arminmeh arminmeh requested a review from JCQuintas May 27, 2025 10:28
@arminmeh arminmeh added scope: data grid Changes related to the data grid. scope: charts Changes related to the charts. labels May 27, 2025
Copy link

codspeed-hq bot commented May 27, 2025

CodSpeed Performance Report

Merging #18021 will not alter performance

Comparing arminmeh:charts-integration (3ef4d69) with master (edfd946)1

Summary

✅ 12 untouched

Footnotes

  1. No successful run was found on master (cf468cd) during the generation of this report, so edfd946 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 28, 2025

This comment was marked as resolved.

Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start!

@arminmeh arminmeh force-pushed the charts-integration branch from 60c79b9 to 30c014f Compare June 3, 2025 08:51
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jun 3, 2025
@arminmeh arminmeh force-pushed the charts-integration branch from 75f0d7b to 5fa75f9 Compare June 4, 2025 09:24
@arminmeh arminmeh force-pushed the charts-integration branch 2 times, most recently from c78c758 to 7aa6363 Compare June 5, 2025 08:13
@arminmeh arminmeh force-pushed the charts-integration branch from 6e348f4 to cddbaaf Compare June 5, 2025 12:27
@arminmeh arminmeh force-pushed the charts-integration branch 3 times, most recently from 9fbb266 to 22a2796 Compare June 11, 2025 14:48
@arminmeh arminmeh force-pushed the charts-integration branch from d1089a9 to 003956a Compare June 16, 2025 10:39
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 22, 2025
@arminmeh arminmeh merged commit bbbcfd5 into mui:master Sep 22, 2025
22 of 23 checks passed
@arminmeh arminmeh deleted the charts-integration branch September 22, 2025 08:42
bernardobelchior pushed a commit to bernardobelchior/mui-x that referenced this pull request Sep 22, 2025
Co-authored-by: Jose Quintas <[email protected]>
Co-authored-by: Kenan Yusuf <[email protected]>
Co-authored-by: mapache-salvaje <[email protected]>
@arminmeh arminmeh mentioned this pull request Sep 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plan: Premium Impact at least one Premium user. scope: charts Changes related to the charts. scope: data grid Changes related to the data grid. type: new feature Expand the scope of the product to solve a new problem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[data grid] Add data visualization / charts