-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[DataGridPremium] [charts-premium] Grid-Charts integration #18021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Localization writing tips ✍️Seems you are updating localization 🌍 files. Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️
Deploy preview: https://deploy-preview-18021--material-ui-x.netlify.app/ Updated pages:
Bundle size report
|
packages/x-data-grid-premium/src/context/GridChartsRendererBridge.tsx
Outdated
Show resolved
Hide resolved
packages/x-data-grid-premium/src/context/GridChartsRendererBridge.tsx
Outdated
Show resolved
Hide resolved
CodSpeed Performance ReportMerging #18021 will not alter performanceComparing Summary
Footnotes |
packages/x-data-grid-premium/src/context/GridChartsRendererBridge.tsx
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start!
packages/x-data-grid-premium/src/hooks/features/chartsIntegration/useGridChartsIntegration.ts
Outdated
Show resolved
Hide resolved
packages/x-data-grid-premium/src/hooks/features/chartsIntegration/useGridChartsIntegration.ts
Outdated
Show resolved
Hide resolved
packages/x-data-grid-premium/src/hooks/features/chartsIntegration/useGridChartsIntegration.ts
Outdated
Show resolved
Hide resolved
docs/data/data-grid/charts-integration/GridChartsIntegrationExample.tsx
Outdated
Show resolved
Hide resolved
60c79b9
to
30c014f
Compare
75f0d7b
to
5fa75f9
Compare
c78c758
to
7aa6363
Compare
packages/x-data-grid-premium/src/hooks/features/chartsIntegration/useGridChartsIntegration.ts
Outdated
Show resolved
Hide resolved
6e348f4
to
cddbaaf
Compare
9fbb266
to
22a2796
Compare
...x-data-grid-premium/src/components/chartsConfigurationPanel/GridChartsConfigurationPanel.tsx
Outdated
Show resolved
Hide resolved
...x-data-grid-premium/src/components/chartsConfigurationPanel/GridChartsConfigurationPanel.tsx
Outdated
Show resolved
Hide resolved
d1089a9
to
003956a
Compare
Co-authored-by: mapache-salvaje <[email protected]> Signed-off-by: Armin Mehinovic <[email protected]>
a05c39b
to
386778e
Compare
Co-authored-by: Jose Quintas <[email protected]> Co-authored-by: Kenan Yusuf <[email protected]> Co-authored-by: mapache-salvaje <[email protected]>
Previews:
https://deploy-preview-18021--material-ui-x.netlify.app/x/react-data-grid/charts-integration/
https://deploy-preview-18021--material-ui-x.netlify.app/x/react-charts/data-grid-integration/
Todo:
Add support for multiple categories- Initially charts will be limited to one category. Multiple categories support is a follow-upAdjust (create new) data set to better demo the featurePivoting examples are looking nicex-charts-premium
for release - [charts-premium] Makex-charts-premium
releasable #18959Out of scope:
Points added to the follow-up issue #19435