[docs] Fix 404 links #15575
[docs] Fix 404 links #15575
Conversation
|
Deploy preview: https://deploy-preview-15575--material-ui-x.netlify.app/ Updated pages: |
| /** | ||
| * @ignore - internal component. | ||
| */ |
There was a problem hiding this comment.
Even if it's applied to a different component, the shouldSkip logic triggers before we ever try to read the jsdocs of the components (to be faster), so we have to remove this. to get the API page of HeatmapTooltip to generate.
We missed this in #15154
| function TreeItemProvider(props: TreeItemProviderProps) { | ||
| const { children, itemId, id } = props; | ||
| const { wrapItem, instance, store } = useTreeViewContext<[]>(); | ||
| const treeId = useSelector(store, selectorTreeViewId); | ||
| const idAttribute = generateTreeItemIdAttribute({ itemId, treeId, id }); | ||
|
|
||
| return wrapItem({ children, itemId, instance, idAttribute }); | ||
| return <React.Fragment>{wrapItem({ children, itemId, instance, idAttribute })}</React.Fragment>; |
There was a problem hiding this comment.
We can remove this once mui/material-ui#44516 lands.
We missed this in #14913
| @@ -63,321 +63,4 @@ function ChartDataProviderPro(props: ChartDataProviderProProps) { | |||
| ); | |||
| } | |||
|
|
|||
| ChartDataProviderPro.propTypes = { | |||
There was a problem hiding this comment.
This is dead code, ChartDataProviderPro is a private API so shouldn't have prop types. It also happens to be wrong, go to https://next.mui.com/x/react-charts/heatmap/ and you will get a runtime warning with the width prop required.
We missed this in #15375.
| ```diff | ||
| - import { usePickersTranslations } from '@mui/x-date-pickers/hooks'; | ||
| - import { usePickersTranslations } from '@mui/x-date-pickers'; | ||
| - import { usePickersTranslations } from '@mui/x-date-pickers-pro'; | ||
| -import { usePickersTranslations } from '@mui/x-date-pickers/hooks'; | ||
| -import { usePickersTranslations } from '@mui/x-date-pickers'; | ||
| -import { usePickersTranslations } from '@mui/x-date-pickers-pro'; |
There was a problem hiding this comment.
Fix git diff format
There was a problem hiding this comment.
Is there a way to lint such cases to avoid introducing incorrect diffs in the first place? 🤔
There was a problem hiding this comment.
It's possible yes. I did a first pass a long time ago https://github.com/mui/material-ui/blob/master/packages/markdownlint-rule-mui/git-diff.js. We could do another, I didn't think about this case.
We can simply make sure that each diff resets the spacing, in a way that there is is no visual spacing offsets, e.g.
- foo() {}
- bar;
+foo() {}
+ bar;@samuelsycamore if you are looking for some small writing code + some algorithmic exercises, up for grab 😄. I can allocate time to review it.
There was a problem hiding this comment.
Moved to an issue mui/mui-public#249.
| components: Heatmap, HeatmapPlot, DefaultHeatmapTooltip | ||
| components: Heatmap, HeatmapPlot, HeatmapTooltip |
There was a problem hiding this comment.
The correct name
oliviertassinari
force-pushed
the
fix-404-links-v2
branch
2 times, most recently
from
2c06cf3 to
942840a
Compare
oliviertassinari
added
type: bug
| ```diff | ||
| - import { usePickersTranslations } from '@mui/x-date-pickers/hooks'; | ||
| - import { usePickersTranslations } from '@mui/x-date-pickers'; | ||
| - import { usePickersTranslations } from '@mui/x-date-pickers-pro'; | ||
| -import { usePickersTranslations } from '@mui/x-date-pickers/hooks'; | ||
| -import { usePickersTranslations } from '@mui/x-date-pickers'; | ||
| -import { usePickersTranslations } from '@mui/x-date-pickers-pro'; |
There was a problem hiding this comment.
Is there a way to lint such cases to avoid introducing incorrect diffs in the first place? 🤔
oliviertassinari
force-pushed
the
fix-404-links-v2
branch
from
942840a to
034674d
Compare
Diving a bit, a bit too deep actually, but 😁
The new API pages: