Skip to content

Conversation

arminmeh
Copy link
Contributor

@arminmeh arminmeh commented Dec 3, 2024

Adds missing preset-safe for the data grid
#15659 helped detect that

I have added pickers section to the readme

Also, I have aligned formatting for the diffs in the readme (spacing for changed and unchanged lines)

@mui-bot
Copy link

mui-bot commented Dec 3, 2024

Deploy preview: https://deploy-preview-15709--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 9a762ab

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refinement. 👍

P.S. WDYT about using the codemod prefix for the PR?
It directly impacts the package. 🤔

@arminmeh
Copy link
Contributor Author

arminmeh commented Dec 3, 2024

P.S. WDYT about using the codemod prefix for the PR?
It directly impacts the package. 🤔

I have used the linked PR as a reference (same situation), I don't mind having it either way

@LukasTy LukasTy changed the title [code-infra] Add missing preset-safe for the data-grid [codemod] Add missing preset-safe for the data-grid Dec 3, 2024
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👌
Thanks for the adjustments. 💯 🙏

@arminmeh arminmeh merged commit b3e67a0 into mui:master Dec 3, 2024
18 checks passed
@arminmeh arminmeh deleted the codemod-v8-fix branch December 3, 2024 14:05
LukasTy added a commit to LukasTy/mui-x that referenced this pull request Dec 19, 2024
Signed-off-by: Armin Mehinovic <[email protected]>
Co-authored-by: Lukas Tyla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: codemod Specific to codemod.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants