Skip to content

Conversation

@DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Dec 10, 2024

Final backports from v6 to v5 required to bump to React 19

Cherry-picks:

Besides, there are some one-off changes:

@DiegoAndai DiegoAndai added typescript internal Behind-the-scenes enhancement. Formerly called “core”. v5.x labels Dec 10, 2024
@DiegoAndai DiegoAndai self-assigned this Dec 10, 2024
@mui-bot
Copy link

mui-bot commented Dec 10, 2024

Netlify deploy preview

@material-ui/core: parsed: +0.16% , gzip: +0.26%
@material-ui/lab: parsed: +0.31% , gzip: +0.46%
@material-ui/system: parsed: +1.85% , gzip: +1.84%
@mui/joy: parsed: +0.30% , gzip: +0.47%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 3ca0f78

@DiegoAndai
Copy link
Member Author

@aarongarciah do these errors sound familiar? https://app.circleci.com/pipelines/github/mui/material-ui/144516/workflows/f9d4bf5f-1cf1-453d-8cd4-91a2df77cf51/jobs/778084

I'll debug them tomorrow. I'm just checking in case you have already gone through them in the past 😅. It's working on master, so I don't know what's missing to cherry-pick.

@aarongarciah
Copy link
Member

aarongarciah commented Dec 10, 2024

@DiegoAndai is it the same issue as mui/mui-x#15769 (comment)?

Re the error in useClipboardCopy.ts, it seems we need to pass undefined to useRef in:

const timeout = React.useRef<ReturnType<typeof setTimeout>>();

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Dec 11, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Dec 11, 2024
@DiegoAndai DiegoAndai marked this pull request as ready for review December 11, 2024 19:56
@DiegoAndai
Copy link
Member Author

DiegoAndai commented Dec 11, 2024

@aarongarciah in case you want to review again, there has been a lot of changes since yesterday, but it's ready now 😅

Sorry for opening it so soon, but I had to work with the CI.

I added more detail in the description about the changes included in the PR.

Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚛️🚀

@DiegoAndai DiegoAndai merged commit dd990df into mui:v5.x Dec 11, 2024
21 checks passed
@DiegoAndai DiegoAndai deleted the bump-react-19-v5-2 branch December 11, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”. typescript v5.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants