Skip to content

Conversation

@DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Dec 6, 2024

Argos is having trouble with #42824 as that PR was created from the next branch. Recreating here to try to fix argos

@DiegoAndai DiegoAndai added internal Behind-the-scenes enhancement. Formerly called “core”. integration: react About improving React support. labels Dec 6, 2024
@DiegoAndai DiegoAndai self-assigned this Dec 6, 2024
@DiegoAndai DiegoAndai changed the title [core] Bump React to 19 2.0 [core] Bump React to 19 (2.0) Dec 6, 2024
@mui-bot
Copy link

mui-bot commented Dec 6, 2024

Netlify deploy preview

ImageListItem: parsed: -1.34% 😍, gzip: -1.20% 😍
ToggleButtonGroup: parsed: -1.29% 😍, gzip: -1.19% 😍
MenuList: parsed: -1.30% 😍, gzip: -1.15% 😍
AvatarGroup: parsed: -1.22% 😍, gzip: -1.08% 😍
BottomNavigation: parsed: -1.34% 😍, gzip: -1.20% 😍
Accordion: parsed: -1.12% 😍, gzip: -0.98% 😍
@material-ui/core: parsed: -0.16% 😍, gzip: -0.10% 😍
TextField: parsed: -0.53% 😍, gzip: -0.32% 😍
@material-ui/lab: parsed: -0.28% 😍, gzip: -0.18% 😍
TabList: parsed: -0.79% 😍, gzip: -0.43% 😍
SpeedDial: parsed: -0.80% 😍, gzip: -0.43% 😍
Breadcrumbs: parsed: -0.85% 😍, gzip: -0.45% 😍

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 31f20ab

@DiegoAndai
Copy link
Member Author

DiegoAndai commented Dec 6, 2024

The argos failed test comes from the animated progress bar, looks like one of the demos loaded a bit faster so it's sitting at ~5% instead of 0%

Looks good in the preview: https://deploy-preview-44672--material-ui.netlify.app/material-ui/react-progress/#linear-determinate

@DiegoAndai
Copy link
Member Author

Regarding the Next.js 15.0.4 bump, smoke testing the docs looks good

Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs and demos seem to work just fine.

Amazing work! 🎉

@DiegoAndai
Copy link
Member Author

DiegoAndai commented Dec 6, 2024

@DiegoAndai DiegoAndai requested a review from a team December 6, 2024 16:18
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find anything broken 👌

@DiegoAndai DiegoAndai merged commit 6381e29 into mui:master Dec 9, 2024
24 checks passed
@DiegoAndai DiegoAndai deleted the react-19-2 branch December 9, 2024 14:59
DiegoAndai added a commit to DiegoAndai/material-ui that referenced this pull request Dec 10, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 28, 2024

@DiegoAndai
Copy link
Member Author

@oliviertassinari I created an issue to track this (#44920), I'll investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration: react About improving React support. internal Behind-the-scenes enhancement. Formerly called “core”.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants