Skip to content

[core] Remove custom hooks from the mui-name-matches-component-name linting rule #42773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2024
Merged

[core] Remove custom hooks from the mui-name-matches-component-name linting rule #42773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a0bb04
[core] Remove custom hooks from the mui-name-matches-component-name l…
flaviendelangle Jun 27, 2024
670eb95
Merge branch 'next' into eslint-config
flaviendelangle Jul 15, 2024
708dce0
Add to README
flaviendelangle Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,16 +446,7 @@ module.exports = {
files: ['packages/*/src/**/*{.ts,.tsx,.js}'],
excludedFiles: ['*.d.ts', '*.spec.ts', '*.spec.tsx', 'packages/mui-joy/**/*{.ts,.tsx,.js}'],
rules: {
'material-ui/mui-name-matches-component-name': [
'error',
{
customHooks: [
'useDatePickerDefaultizedProps',
'useDateTimePickerDefaultizedProps',
'useTimePickerDefaultizedProps',
],
},
],
'material-ui/mui-name-matches-component-name': 'error',
},
},
{
Expand Down
5 changes: 5 additions & 0 deletions packages/eslint-plugin-material-ui/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Custom eslint rules for MUI.

- `disallow-active-element-as-key-event-target`
- `docgen-ignore-before-comment`
- `mui-name-matches-component-name`
- `no-hardcoded-labels`
- `rules-of-use-theme-variants`
- ~~`restricted-path-imports`~~
Expand All @@ -20,6 +21,10 @@ we use already verifies that the passed target can be the target of a

Enforce correct usage of `@ignore` in the prop-types block comments.

### mui-name-matches-component-name

Enforce that the name passed to the `useThemeProps` and `useDefaultProps` hooks matches the component name.

### no-hardcoded-labels

Prevent the usage of hardcoded labels.
Expand Down