Skip to content

Conversation

@flaviendelangle
Copy link
Member

The config now lives on the X repo.
And these custom hooks are blocking the PigmentCSS migration on the pickers.

@flaviendelangle flaviendelangle self-assigned this Jun 27, 2024
@flaviendelangle flaviendelangle added the internal Behind-the-scenes enhancement. Formerly called “core”. label Jun 27, 2024
@mui-bot
Copy link

mui-bot commented Jun 27, 2024

Netlify deploy preview

https://deploy-preview-42773--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 708dce0

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Had to dig a bit more than needed to figure out what this does. If you're up for it, I'd suggest to update the README with a short description of what this rule is supposed to cover.

@flaviendelangle
Copy link
Member Author

I can add it to the README, but checking its implementation changed in #42638

@siriwatknp does it mean that the rule will stop working with useThemeProps?
We are still using useThemeProps in MUI X and we can't migrate to useDefaultProps before the next major.
Also I just migrated all the pickers to use createUseThemeProps and I see that you removed its usages in the pull request above 😬 , if you could communicate any change in DX around the Pigment CSS migration to avoid back and forth work on our side that would be great.

@siriwatknp
Copy link
Member

@siriwatknp does it mean that the rule will stop working with useThemeProps? We are still using useThemeProps in MUI X and we can't migrate to useDefaultProps before the next major. Also I just migrated all the pickers to use createUseThemeProps and I see that you removed its usages in the pull request above 😬 , if you could communicate any change in DX around the Pigment CSS migration to avoid back and forth work on our side that would be great.

Nope, I reverted in #42817. It should work the same for MUI X.

@flaviendelangle
Copy link
Member Author

👌 awesome
I'll add some doc about this lint rule in the README before merging this PR then

@flaviendelangle flaviendelangle merged commit 2f481a0 into mui:next Jul 15, 2024
@flaviendelangle flaviendelangle deleted the eslint-config branch July 15, 2024 11:38
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants