-
-
Notifications
You must be signed in to change notification settings - Fork 36.2k
Examples: Update with the new style and inspector #31907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
WebGLBackend is not fully compatible with inspector and is crashing the examples in E2E tests, I will disable it for now. |
|
It seems the FPS does not update after this PR. |
I disabled it for WebGLBackend, I'm still going to create a version that doesn't crash on E2E. |
|
Understood! When you think the inspector is robust enough, I can help with adding it to the WebGPU examples so they all benefit from the new beautiful UI. |
I think we can start migrating, when I enable the WebGLBackend version there shouldn't be any changes in the examples, this could even help with testing. I didn't add the button in the GUI yet, but I think some examples that use it can use booleans instead like webgpu_layers (Edit: Hmm, now that I see there's an enable all, I'll added the button if you find it necessary) If you find any bugs, you can tag me and I will do my best to fix them as quickly as possible. |
Related issue: #31869
Description