Skip to content

NodeMaterialObserver: Add checking the lights #31440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2025
Merged

NodeMaterialObserver: Add checking the lights #31440

merged 3 commits into from
Jul 18, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jul 18, 2025

Fixes #31430
Related issue: #31396, #31330

Description

This reverts the cache PR, which can be useful if the texture is in a different format and the shader needs to be rebuilt. It also only checks the light for SpotLight that have the .map.

@sunag sunag added this to the r179 milestone Jul 18, 2025
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.02
78.86
338.02
78.86
+0 B
+0 B
WebGPU 558.57
154.64
559.01
154.76
+444 B
+118 B
WebGPU Nodes 557.49
154.42
557.93
154.54
+444 B
+119 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 469.28
113.56
469.28
113.56
+0 B
+0 B
WebGPU 633.86
171.66
634.3
171.8
+444 B
+133 B
WebGPU Nodes 588.99
160.99
589.44
161.12
+444 B
+123 B

@sunag sunag marked this pull request as ready for review July 18, 2025 16:54
@sunag sunag merged commit 8a318e4 into mrdoob:dev Jul 18, 2025
9 checks passed
@sunag sunag deleted the dev-rev branch July 18, 2025 17:05
@ycw
Copy link
Contributor

ycw commented Jul 21, 2025

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frames drop if projector light is using VideoTexture
2 participants