LightsNode: Honor map version in cache key. #31396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #31330
Description
The custom cache key of
LightsNode
must honor the version of spot light maps otherwise a texture update is not correctly honored.webgpu_lights_projector
only worked since the material observer forces a refresh for each newrenderId
. But if you add more than one objects that share a node builder state (and thus material observer) and are affected by the spot light, textured lighting breaks for all objects except the first one.Note: The video texture also works now but there are still WebGPU warnings in the console:
WebGL reports no warnings. Investigating this separately.